-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
precompile: if a single package is requested, show output live #3582
precompile: if a single package is requested, show output live #3582
Conversation
An alternative would be for code loading precompilation to parallel precomp all of the depdendencies but leave off the requested package, then exit and leave the old serial precompilation to finish the main package like it used to. |
Seems useful, but also a bit odd to see the output repeated twice. I like the concept of having output appear as each task finishes for each process. For comparison, in |
3362066
to
4daeb0f
Compare
It's an interesting idea, but would be a bigger change with some tricky UX because of the way packages disappear when done. This PR is a bit more manageable in UX because it only happens to the last singular package being precompiled. |
4daeb0f
to
2bac967
Compare
Marking this for 1.10 backport because the reported issue was introduced by code load parallel precompile which was introduced in 1.10 |
Let's get this on master to get it tried out |
(cherry picked from commit 08e1eb6)
Fixes #3487
@vtjnash something like this, perhaps?