Ensure that string(::VersionSpec) is compatible with semver_spec()
#3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is an unfortunate coincidence that if you try to print out a `VersionSpec` to a project's `compat` field, it can be in a format that `semver_spec()` rejects due to the ambiguity of `1.2.0-1.4.0` being either a prerelease with a very strange prerelease tag, or a range of versions. We reduce the ambiguity by changing `VersionSpec` to always print its bounds with a separating space.
staticfloat
force-pushed
the
sf/consistent_version_spec
branch
from
9a91b11
to
92743f5
Compare
bors bot
added a commit
to JuliaRegistries/RegistryCI.jl
that referenced
this pull request
Oct 16, 2023
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
bors bot
added a commit
to JuliaRegistries/RegistryCI.jl
that referenced
this pull request
Oct 16, 2023
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
bors bot
added a commit
to JuliaRegistries/RegistryCI.jl
that referenced
this pull request
Oct 16, 2023
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
bors bot
added a commit
to JuliaRegistries/RegistryCI.jl
that referenced
this pull request
Oct 16, 2023
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
bors bot
added a commit
to JuliaRegistries/RegistryCI.jl
that referenced
this pull request
Oct 16, 2023
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
bors bot
added a commit
to JuliaRegistries/RegistryCI.jl
that referenced
this pull request
Oct 16, 2023
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
bors bot
added a commit
to JuliaRegistries/RegistryCI.jl
that referenced
this pull request
Oct 16, 2023
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
bors bot
added a commit
to JuliaRegistries/RegistryCI.jl
that referenced
this pull request
Oct 19, 2023
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
bors bot
added a commit
to JuliaRegistries/RegistryCI.jl
that referenced
this pull request
Oct 19, 2023
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is an unfortunate coincidence that if you try to print out a
VersionSpecto a project'scompatfield, it can be in a format thatsemver_spec()rejects due to the ambiguity of1.2.0-1.4.0being either a prerelease with a very strange prerelease tag, or a range of versions. We reduce the ambiguity by changingVersionSpecto always print its bounds with a separating space.