Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcm_write needs aux_vr = dcm_data.vr to function properly, at least on all my dicom files! #93

Open
curtcorum opened this issue Aug 3, 2024 · 1 comment

Comments

@curtcorum
Copy link

curtcorum commented Aug 3, 2024

Thanks to the developers for DICOM.jl package!

I noticed that I needed the following to get valid modified dicom files.

Julia 1.10.4, Ubuntu 20.04, and latest DICOM.jl

dcm_write( file_name, dcm_data) results in an invalid dicom file. dcm_data is read first via dcm_parse and then has the SeriesDescription tag modified.

dcm_write( file_name, dcm_data, aux_vr = dcm_data.vr) works great!

My guess would be that dcm_write would use dcm_data.vr as the default and override only if the aux_vr argument is given?

Anyway, I have not looked at the code. Was this changed by #85 or #87 somehow?

If there is reason for not having the above expected default behavior it might be noted that dcm_write( file_name, dcm_data, aux_vr = dcm_data.vr) for some (all?) files in the docstring, etc.

@curtcorum
Copy link
Author

Apologies if already fixed, I am using:

pkgversion( DICOM)
v"0.11.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant