Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Crater to Volcano Topography #146

Open
aelligp opened this issue Oct 28, 2024 · 0 comments
Open

Adding Crater to Volcano Topography #146

aelligp opened this issue Oct 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@aelligp
Copy link
Collaborator

aelligp commented Oct 28, 2024

When adding a crater to a volcano it adds an artificial kink in the topography compared to the plain cone shape without.

EDIT: add_volcano() is not in the tests

Without Crater:
Screenshot 2024-10-28 at 10 10 00

With Crater of 0.5km:
Screenshot 2024-10-28 at 10 10 49

Here is a MWE for this setup:

    Lx = Ly = 50
    x = range(0.0, Lx, nx);
    y = range(0.0, Ly, 2);
    z = range(-25.0, 5.0, nz);
    Grid = CartData(xyz_grid(x,y,z));

    Phases = fill(4, nx, 2, nz);

    Temp = fill(0.0, nx, 2, nz);

    add_box!(Phases, Temp, Grid;
        xlim=(minimum(Grid.x.val), maximum(Grid.x.val)),
        ylim=(minimum(Grid.y.val), maximum(Grid.y.val)),
        zlim=(minimum(Grid.z.val), 0.0),
        phase = LithosphericPhases(Layers=[30], Phases=[1]),
        T = HalfspaceCoolingTemp(Age=11)
    )

    add_volcano!(Phases, Temp, Grid;
    volcanic_phase  = 1,
    center          = (mean(Grid.x.val),  0.0),
    height          = 3,
    radius          = 5,
    # crater          = 0.5,
    base            = 0.0,
    background      = nothing,
    T               = HalfspaceCoolingTemp(Age=20)
    )

    add_ellipsoid!(Phases, Temp, Grid;
        cen    = (mean(Grid.x.val), 0,-5.0),
        axes   = (3.5, 2.5, 2.0),
        phase  = ConstantPhase(2),
        T      = ConstantTemp(T=1000)
    )
    add_sphere!(Phases, Temp, Grid;
    cen = (mean(Grid.x.val), 0,-5.0),
    radius = 0.5,
    phase  = ConstantPhase(3),
    T      = ConstantTemp(T=1100)
    )
    add_cylinder!(Phases, Temp, Grid;
    base = (mean(Grid.x.val), 0, -3.25),
    cap  = (mean(Grid.x.val), 0, 3.00),
    radius = 0.05,
    phase  = ConstantPhase(2),
    T      = ConstantTemp(T=1000),
    )

    Grid = addfield(Grid,(; Phases, Temp))


    li = (abs(last(x)-first(x)), abs(last(z)-first(z)))
    origin = (x[1], z[1])

    ph      = Phases[:,1,:]
    T       = Temp[:,1,:]
    # write_paraview(Grid, "Volcano2D")
@aelligp aelligp added the bug Something isn't working label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant