Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare ground for nested structs #95

Merged
merged 7 commits into from
Mar 24, 2024
Merged

Prepare ground for nested structs #95

merged 7 commits into from
Mar 24, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Mar 24, 2024

Core

  • Add Functors.jl dependency
  • Use true as a non-promoting 1 value for gradient as pullback

Test

  • Go grab some functions with get_extension(...).test_blabla instead of defining empty stubs in DifferentiationTest
  • Separate error-free testing from the JET extension
  • Implement recursive isapprox
  • Clarify scenario constructor
  • Start nested scenarios

Extensions

  • Move correctness testing to its own extension which requires Zygote + ForwardDiff (in anticipation of arbitrary structs)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.92086% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.85%. Comparing base (81d2e83) to head (20e3c53).

Files Patch % Lines
...tExt/DifferentiationInterfaceCorrectnessTestExt.jl 98.80% 1 Missing ⚠️
src/DifferentiationTest/test_differentiation.jl 93.33% 1 Missing ⚠️
src/utils.jl 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   93.00%   93.85%   +0.85%     
==========================================
  Files          53       56       +3     
  Lines        1243     1335      +92     
==========================================
+ Hits         1156     1253      +97     
+ Misses         87       82       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review March 24, 2024 19:49
@gdalle gdalle merged commit 448f8d6 into main Mar 24, 2024
2 checks passed
@gdalle gdalle deleted the gd/nested branch March 25, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants