Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customizable DIT benchmarks #636

Merged
merged 3 commits into from
Nov 24, 2024
Merged

feat: customizable DIT benchmarks #636

merged 3 commits into from
Nov 24, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Nov 23, 2024

DIT source

Add two benchmark-related options to DIT.test_differentiation and DIT.benchmark_differentiation:

  • benchmark_seconds=1: duration of each benchmark
  • benchmark_aggregation=minimum: metric aggregation over samples

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (2743e18) to head (34b3630).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #636   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files         111      111           
  Lines        5551     5551           
=======================================
  Hits         5414     5414           
  Misses        137      137           
Flag Coverage Δ
DI 98.65% <ø> (ø)
DIT 95.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gdalle gdalle changed the title feat: allow custom max duration in DIT benchmarks feat: customizable DIT benchmarks Nov 23, 2024
@gdalle gdalle merged commit 6b55559 into main Nov 24, 2024
46 of 47 checks passed
@gdalle gdalle deleted the gd/bench_duration branch November 24, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant