Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove randomness in scenario creation #623

Merged
merged 2 commits into from
Nov 13, 2024
Merged

refactor!: remove randomness in scenario creation #623

merged 2 commits into from
Nov 13, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Nov 13, 2024

Versions

  • Bump DIT to v0.9.0 (BREAKING CHANGE)

DIT source

  • Remove use of random number generators for most scenario creations (except Lux and Flux). Use fixed values for x, y, dx, dy instead (aka manual randomness).

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (1e012dc) to head (2d616f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #623   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files         112      112           
  Lines        5530     5533    +3     
=======================================
+ Hits         5404     5407    +3     
  Misses        126      126           
Flag Coverage Δ
DI 98.95% <ø> (ø)
DIT 95.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 675b4bd into main Nov 13, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant