Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow benchmark_differentiation to (also) record the mean time #622

Closed
nsiccha opened this issue Nov 12, 2024 · 3 comments · Fixed by #639
Closed

Allow benchmark_differentiation to (also) record the mean time #622

nsiccha opened this issue Nov 12, 2024 · 3 comments · Fixed by #639
Labels
test Related to the testing subpackage

Comments

@nsiccha
Copy link

nsiccha commented Nov 12, 2024

Currently (I think) DifferentiationInterfaceTest.benchmark_differentiation only records the minimum benchmark runtime (see

), but it would also be nice to be able to choose the mean benchmark runtime.

@gdalle
Copy link
Member

gdalle commented Nov 12, 2024

That's a good idea! I think the best way is to add a keyword argument like "benchmark_aggregation" which defaults to the min function, and use it when aggregating samples.

@gdalle gdalle changed the title Allow DifferentiationInterfaceTest.benchmark_differentiation to (also) record the mean time Allow benchmark_differentiation to (also) record the mean time Nov 20, 2024
@gdalle
Copy link
Member

gdalle commented Nov 24, 2024

@nsiccha I think #639 gives you the flexibility you need

@gdalle gdalle linked a pull request Nov 24, 2024 that will close this issue
@gdalle gdalle added the test Related to the testing subpackage label Nov 24, 2024
@nsiccha
Copy link
Author

nsiccha commented Nov 25, 2024

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to the testing subpackage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants