Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong mode pushforwards and pullbacks #61

Closed
gdalle opened this issue Mar 18, 2024 · 1 comment
Closed

Wrong mode pushforwards and pullbacks #61

gdalle opened this issue Mar 18, 2024 · 1 comment

Comments

@gdalle
Copy link
Member

gdalle commented Mar 18, 2024

Should we make pushforwards available in reverse mode, and pullbacks available in forward mode?
The code is already there, we only need to push it one level up in the call tree:

https://github.com/gdalle/DifferentiationInterface.jl/blob/964c85645cf232f6629f3f6cc7ebefd752c98889/src/gradient.jl#L16-L25

https://github.com/gdalle/DifferentiationInterface.jl/blob/964c85645cf232f6629f3f6cc7ebefd752c98889/src/multiderivative.jl#L46-L55

The only thing we don't have yet is a JVP in reverse mode and VJP in forward mode

@gdalle
Copy link
Member Author

gdalle commented Mar 19, 2024

Closing because #64 is ugly

@gdalle gdalle closed this as completed Mar 19, 2024
@gdalle gdalle reopened this Mar 19, 2024
@gdalle gdalle closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant