Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Mutable)DiffResult allocates because it's a mutable struct #46

Closed
gdalle opened this issue Mar 15, 2024 · 3 comments
Closed

(Mutable)DiffResult allocates because it's a mutable struct #46

gdalle opened this issue Mar 15, 2024 · 3 comments
Labels
wontfix This will not be worked on

Comments

@gdalle
Copy link
Member

gdalle commented Mar 15, 2024

That probably explains the one allocation we see even with optimal config on ForwardDiff and ReverseDiff
@gdalle
Copy link
Member Author

gdalle commented Mar 15, 2024

The answer might be to include it in extras

@gdalle
Copy link
Member Author

gdalle commented Mar 15, 2024

JuliaDiff/DiffResults.jl#26

@gdalle
Copy link
Member Author

gdalle commented Mar 25, 2024

No improvement possible because we cannot put it in extras. Otherwise future gradient calls might modify something we have already returned

@gdalle gdalle closed this as completed Mar 25, 2024
@gdalle gdalle added the wontfix This will not be worked on label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdalle