Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress on nested scenarios for Flux #100

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Progress on nested scenarios for Flux #100

merged 3 commits into from
Mar 25, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Mar 25, 2024

Core

  • Improve all the my... functions with Functors

Tests

  • Add more complicated nested scenarios, test them on Zygote and Tracker

Extensions

  • ForwardDiff: use Functors on dual-specific functions to be more generic
  • Tracker: use withgradient by default (more modern), with a fallback for number inputs

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 78.08219% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 93.84%. Comparing base (36d9c47) to head (11e065f).

Files Patch % Lines
src/utils.jl 55.00% 9 Missing ⚠️
...xt/DifferentiationInterfaceForwardDiffExt/utils.jl 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   94.51%   93.84%   -0.68%     
==========================================
  Files          58       58              
  Lines        1477     1526      +49     
==========================================
+ Hits         1396     1432      +36     
- Misses         81       94      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 2ea4ec9 into main Mar 25, 2024
2 checks passed
@gdalle gdalle deleted the gd/nested_scenarios branch March 26, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants