Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadps4 emulator support #3897

Open
Gentleman2292 opened this issue Dec 25, 2024 · 9 comments
Open

shadps4 emulator support #3897

Gentleman2292 opened this issue Dec 25, 2024 · 9 comments

Comments

@Gentleman2292
Copy link

Feature description

i would like to be able to add shadps4 games quickly from the shadps4 emulator to playnite
https://github.com/shadps4-emu/shadPS4/

Screenshots

No response

@vaughngx4
Copy link

Is anyone working on this? Is it possible to implement this before the Playnite 11 beta is released? Wouldn't mind taking a crack at it.

@JosefNemec
Copy link
Owner

You can add any emulator you want manually without explicit support from Playnite https://api.playnite.link/docs/manual/features/emulationSupport/addingNewEmulators.html#manual-emulator-configuration

@vaughngx4
Copy link

vaughngx4 commented Jan 1, 2025

@JosefNemec shadPS4 requires a scripted scan to import games automatically. Very similar to the RPCS3 script. I've managed to add support in the source code (I've only tested the import script so far) but I've had no luck adding it manually using the "manual emulator configuration" in Playnite itself.

@vaughngx4
Copy link

I've added shadPS4 emulator support on my fork of Playnite (devel-emu_shadps4 branch)). Tested and working. At the request of @JosefNemec I shall not create a pull request until Playnite 11 beta is released.

@vaughngx4
Copy link

vaughngx4 commented Jan 2, 2025

As a temporary solution, anyone who would like to add shadPS4 support to their existing Playnite can download this and extract it to their Playnite install directory. See my fork for changes.

image

@JosefNemec
Copy link
Owner

@vaughngx4 open PR anyways please. Some other things came up and another P10 update is likely now.

@vaughngx4
Copy link

Just realized that I made the PR to the wrong branch. I'm on mobile right now, I will fix it when I get home.

@vaughngx4
Copy link

vaughngx4 commented Jan 4, 2025

@JosefNemec After failing at creating a proper PR twice I shall refer to you for assistance. The ReadMe says to PR to "devel" but my modifications are made on a fork from "master". Should I move my changes to the devel branch before PR or PR directly to master? Apologies for the mess I made... Closed both PRs myself to avoid confusion.

@JosefNemec
Copy link
Owner

Just make your changes against devel then. I updated devel to be more up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants