Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamepage_header.scss function of "height" does not appear to be working after latest update #51

Open
Kennyluzz opened this issue Aug 2, 2022 · 4 comments
Labels
CSS CSS/SCSS styling

Comments

@Kennyluzz
Copy link

Hi, as in the title, changing the height no longer seems to do anything.
"/* App Page main header - down to 60% the height */
.sharedappdetailsheader_TopCapsule_NZMJ6 {
height: 13vw !important;"

I've previously used to set it to 17vw, as well as set "min-height" to 510px, to achieve bigger "hero" images. Now it just crops my background image at the top and blurs the bottom. I'm attaching screenshots of pre- and post-update.
I hope this gets resolved as I am into customizing my covers, backgrounds, etc. Thank you for this great piece of software!

a
b
.

@Potato95
Copy link

Potato95 commented Aug 3, 2022

I managed to get a result similar to the pre-update image of yours. What I did was mess around the Steam Dev mode and write the code I wanted changed in the Old Glory custom module. Here's the file and a preview.

_custom_module1.txt - Remember to change the .txt to .scss and backing up your original _custom_module1, even if you haven't changed it.

image

@Jonius7 Jonius7 added the CSS CSS/SCSS styling label Aug 3, 2022
@Kennyluzz
Copy link
Author

Thanks a lot! Works pretty good, though unfortunately the logo position no longer goes along with it but nonetheless, I am happy.

chrome_n7OfUvSAay

@vini71
Copy link

vini71 commented Aug 3, 2022

Hi Jonius7 and Potato95, thanks for providing your code and program!

I really like to use bigger “hero” images, just like Kennyluzz. I tried Potato95's code, but when I hide the left sidebar and make the image a bit shorter to fix the logo situation, the bottom right buttons are gone, and the image is not adjusting correctly.

Do any of you know how to make the “hero” images show properly when the left sidebar is hidden? And also, thanks Potato95 for finding a way to remove that freaking gradient on top of the hero image, it's so much better this way!

Hero

@Jonius7
Copy link
Owner

Jonius7 commented Aug 10, 2022

I have merged in most of your changes, @Potato95, into the main code.

max-height and min-height are default 170px with margin-bottom: 13px
(Your values for the bigger header are 430px 240px 104px respectively)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS CSS/SCSS styling
Projects
None yet
Development

No branches or pull requests

4 participants