Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game header images (or "heroes,"as they're alternatively called) aren't fully seen #30

Open
orae2 opened this issue Nov 10, 2021 · 1 comment
Labels
CSS CSS/SCSS styling info Advanced info about OldGlory that you may want to know todo stuff that aims to be work-in-progress at some point

Comments

@orae2
Copy link

orae2 commented Nov 10, 2021

Compared to the stock steam layout, the header images for games are a bit smaller and it usually cuts out the main purpose of the image. Like for example in Bioshock Infinite you can't see the main character, but in stock steam you can. In some library themes you can see the rest of the image through some type of glass like area (which is fine but I feel like the full thing would be better) and in shiina's theme you can't see the rest of the image at all. I was thinking maybe a feature could be implemented where the user can change the dimensions of that picture and how much of it the user wants to be shown.

@Jonius7 Jonius7 added the CSS CSS/SCSS styling label Nov 11, 2021
@Jonius7
Copy link
Owner

Jonius7 commented Nov 11, 2021

Compared to the stock steam layout, the header images for games are a bit smaller and it usually cuts out the main purpose of the image.

The header in OldGlory is shorter than in vanilla Steam, so yes, more of the image will be behind the main game page panels. There is also some adjusting made to position the image from the top.

/* Unset Header Image height to show top and bottom */
.sharedappdetailsheader_ImgContainer_QlR9E {
  height: unset;
}

The default height is 120%, changing this number around determines where the top of the image starts from. 202% approximately mimics the positioning from Vanilla Steam.

scss\_gamepage_header.scss contains the layout changes for the header, so disabling this would go back to using the vanilla Steam layout.

Now because CSS is very customisable I could add in lots of variables/options to make this easier to customise at a later date.

I was thinking maybe a feature could be implemented where the user can change the dimensions of that picture and how much of it the user wants to be shown.

This would most likely be options to change across all gamepage images, and not on a game-by-game basis, where a custom image background would be better suited.

@Jonius7 Jonius7 added the todo stuff that aims to be work-in-progress at some point label Nov 11, 2021
@Jonius7 Jonius7 added the info Advanced info about OldGlory that you may want to know label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS CSS/SCSS styling info Advanced info about OldGlory that you may want to know todo stuff that aims to be work-in-progress at some point
Projects
None yet
Development

No branches or pull requests

2 participants