Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game pictures getting cut-off at the bottom. #14

Closed
Rex117 opened this issue Mar 5, 2021 · 5 comments
Closed

Game pictures getting cut-off at the bottom. #14

Rex117 opened this issue Mar 5, 2021 · 5 comments
Labels
CSS CSS/SCSS styling info Advanced info about OldGlory that you may want to know note Note to work on this in upcoming releases

Comments

@Rex117
Copy link

Rex117 commented Mar 5, 2021

Hey there, I am having an issue where the Library horizontal game pictures are getting cut-off when reaching the bottom. How or where should I go to fix this?

steam_library_issue

@Jonius7
Copy link
Owner

Jonius7 commented Mar 6, 2021

You mention in #6 (comment) that you were using an earlier version. Is the problem still showing up for you?

Firstly, I would grab the current version of some .scss files, namely _home_collections.scss and replace (copy and paste) in the OldGlory/scss directory. Install and see if that works.
Then, I would go ahead and click the Remake JS button.

@Rex117
Copy link
Author

Rex117 commented Mar 6, 2021

Hey @Jonius7 thanks for replying and sorry if it seemed like I was spamming the chats, I just don't know if you get a notification when someone comments or when a new thread is created. After reading your posts it made me realize that I had just updated my Steam, from the other solution I was using, and there might have been leftover files. I was using youtuber Leeson's solution: https://www.youtube.com/watch?v=knIfk_-YOS8. I proceeded to re-install Steam and used your video to redo the whole process again from the beginning, which ended with the same result. I then replaced just the _home_collections.scss which resulted in errors to which I just deleted the SteamUI-OldGlory-Release_5.5.3 folder, re-extracted it again and replaced the files in the scss folder with the ones from the SteamUI-OldGlory-master folder. This did not fix the issue either, even after Installing and remaking the JS files. I am not completely clueless when it comes to programming, I just mainly use Python and my JavaScript is almost non-existent. Therefore, if the I have to modify a file to solve this I can, I just can't make sense of everything.

@Jonius7
Copy link
Owner

Jonius7 commented Mar 6, 2021

Ok, I might see a problem.

Are you using Compact (8px 5px) or Default (24px 16px) spacing in CSS Options?

  • If using Default, Home Page Grid Spacing in JS options should be unticked.

I'll look to have this better configured in a later release.

@Rex117
Copy link
Author

Rex117 commented Mar 7, 2021

@Jonius7 you solved it. After unchecking the Home Page Grid Spacing in JS options and Installing it everything looks perfect. Thank you very much!!!! :D

@Jonius7 Jonius7 added CSS CSS/SCSS styling note Note to work on this in upcoming releases labels Mar 10, 2021
@Jonius7 Jonius7 closed this as completed Mar 10, 2021
@Jonius7
Copy link
Owner

Jonius7 commented Mar 28, 2021

For future reference, the "corresponding JavaScript values" are these ones in fixes.txt
2021-03-29 08_29_50-D__New Horizons_Hearthstone_SteamUI-OldGlory_fixes txt - Notepad++

@Jonius7 Jonius7 added the info Advanced info about OldGlory that you may want to know label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS CSS/SCSS styling info Advanced info about OldGlory that you may want to know note Note to work on this in upcoming releases
Projects
None yet
Development

No branches or pull requests

2 participants