Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: jmwalletd dies when creating relative offer with zero fees #1740

Open
theborakompanioni opened this issue Oct 30, 2024 · 1 comment
Open

Comments

@theborakompanioni
Copy link
Contributor

theborakompanioni commented Oct 30, 2024

Starting a maker with a zero relative fee value on regtest via the rpc api crashes the jmwalletd deamon.

POST /wallet/Satoshi.jmdat/maker/start
{
  "ordertype": "sw0reloffer",
  "minsize":"100000",
  "cjfee_a":"0",
  "cjfee_r":"0",
  "txfee":"0"
}
202 Accepted
{}

Logs after

2024-10-28 03:55:56,503 [INFO]  Failed to start after 10 minutes, giving up.
2024-10-28 03:55:56,505 [INFO]  Lost IRC connection to: ergo.test . Should reconnect automatically soon.
2024-10-28 03:55:56,505 [DEBUG]  IRC connection lost: [Failure instance: Traceback (failure with no frames): <class 'twisted.internet.error.ConnectionLost'>: Connection to the other side was lost in a non-clean fashion: Connection lost.
]
2024-10-28 03:55:56,506 [DEBUG]  We got a disconnect event: z5d2ht2jp5w7lbh5hwaygd2ne6l2hsmvepqxrzkavtf53upsg4z4tyid.onion:5222
2024-10-28 03:55:56,506 [INFO]  Going to reattempt connection to z5d2ht2jp5w7lbh5hwaygd2ne6l2hsmvepqxrzkavtf53upsg4z4tyid.onion:5222 in 10.0 seconds.

Note: Trying to stop the maker service with GET /wallet/Satoshi.jmdat/maker/stop (202 Accepted) does not help. Backend dies nonetheless.

@theborakompanioni
Copy link
Contributor Author

Potentially related: #1692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant