Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more than one instance of an extension to be installed #968

Open
area opened this issue Jun 10, 2021 · 3 comments · May be fixed by #971
Open

Allow more than one instance of an extension to be installed #968

area opened this issue Jun 10, 2021 · 3 comments · May be fixed by #971
Assignees
Labels

Comments

@area
Copy link
Member

area commented Jun 10, 2021

To make changing initialization parameters easier, we need to allow one extension to have multiple installations at a time, and for those installations to be findable by the frontend (likely through an event we don't have yet).

@area
Copy link
Member Author

area commented Jun 11, 2021

Token locking/unlocking relies on us knowing if an extension is a network managed extension.

@kronosapiens
Copy link
Member

kronosapiens commented Jun 14, 2021

If we're going to have many simultaneous installations, we can likely provide an "is managed" lookup via a extensionAddress => isOfficial mapping, but probably not a "give me extension" lookup, since by necessity there may be an arbitrary number of extensions. So this change would require knowledge of the extension address to exist external to the contracts. As long as we are ok with that, then this shouldn't be too problematic. IIRC that isn't a problem, since an earlier prototype which relied on this knowledge was (fortunately) abandoned.

Other options are to make the mapping [colonyAddress][extensionAddress] => isOfficial, or perhaps even better extensionAddress => colonyAddress which arguably provides the most information (if the mapping is empty, it is not an official extension, but if it isn't, we know which colony the extension is installed in).

@kronosapiens kronosapiens self-assigned this Jun 15, 2021
@area
Copy link
Member Author

area commented Jun 16, 2021

extensionAddress => colonyAddress

Given this doesn't cost extra than the other options, I think this is probably the winner.

Just as a reminder, remember that any implementation has to work upgrading from the current approach.

@kronosapiens kronosapiens linked a pull request Jun 23, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants