Refactor: Introduce action matchers #288
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubcolony
force-pushed
the
refactor/actions
branch
from
ff23f15 to
6b517b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the block-ingestor assumes there is only a single action in a given transaction, which is incorrect and something we'll have to address as multicall is further rolled out. This PR introduces action matching, a brand new step in block processing that will run after all the events have been processed and handled. Its purpose is to find sequences of events that constitute an action and pass it over to a relevant action handler. That will enable us to process multiple actions in a single transaction.