Fix/contextmenu stuck keys #1152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Going to close to keep my PR list clean. Feel free to re-open if you feel this is helpful. I'll gladly get involved again. Thanks again for such a great library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1151
This fix is a bit different than the
blurstuck keys fix. The problem is that if you're holding a key down, thekeydownevent sometimes fires a few times after thecontextmenuevent, thus setting them again after clear.After quite a bit of testing, I believe the issue is that the
contextmenuevent enqueues beforekeydownevents stop enquing. By callingclearasynchronously (using setTimeout to put it at the end of the queue) this seems to be fixed. I tested theblurfix for this bug, which doesn't seem to exist (in Chrome at least).Given these are events, I don't think addressing it asynchronously is a problem: the behaviour is already async in nature.
Thank you for offering up your time to review my bug report and this proposed fix.