Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with HSV Color Hashing #215

Closed
saim61 opened this issue Dec 4, 2024 · 2 comments
Closed

Issue with HSV Color Hashing #215

saim61 opened this issue Dec 4, 2024 · 2 comments

Comments

@saim61
Copy link

saim61 commented Dec 4, 2024

Hey team,

I noticed a small bug in the HSV algorithm when we go past bin size 43. The function name is colorhash. Its a small fix and I would like to raise a PR for that. Can someone guide me about this?

Thanks,
Saeem
@JohannesBuchner
Copy link
Owner

Pull requests are welcome. I cannot give an introduction to git/github, please find resources online.

@saim61
Copy link
Author

saim61 commented Dec 4, 2024 •
edited by JohannesBuchner
Loading

Apologies for this issue, I wasnt asking for an introduction to git/github. Anyways, I opened a PR and am now closing this issue.

PR link: #216

@saim61 saim61 closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohannesBuchner @saim61