Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store dimensionality in points file #100

Open
JohannesBuchner opened this issue Jul 17, 2023 · 1 comment
Open

store dimensionality in points file #100

JohannesBuchner opened this issue Jul 17, 2023 · 1 comment

Comments

@JohannesBuchner
Copy link
Owner

At the moment, the hdf5 file is agnostic to what it is storing, it simply receives rows.

This is nice for separation of concern.

However, the reader then needs to know the dimensionality of the untransformed points and the transformed points. One can guess (if no added parameters, it is (ncol - 3) / 2), but it is ambiguous whether parameters were added.

To balance these two, it might be good to add to the header

  • the number of untransformed parameters (x_dim)
  • the number of transformed parameters (num_params)

Then read_file can make the dimensionality argument optional.

@JohannesBuchner
Copy link
Owner Author

This could probably be addressed together with #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant