Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Suggestion: Spanned Notes #533

Open
BrightScreenTV opened this issue May 2, 2024 · 5 comments
Open

Feature Suggestion: Spanned Notes #533

BrightScreenTV opened this issue May 2, 2024 · 5 comments

Comments

@BrightScreenTV
Copy link

Hi,

I was wondering if it would be useful to have a notes option on the main graph.

Sometimes I'm asked by a clinician about specific highs or lows on my readings. My idea is that the user would have two extra buttons presented along the bottom of the main screen called 'Note Start' and 'Note End'. When the user taps the first button, a point on the graph could be tapped to mark the start of the highlighted readings. Tapping the second button and then tapping on the graph again marks the end of the highlighted section. Once the buttons are pressed they should probably toggle on/off so that accidentally tapping instead of scrolling the graph can be corrected.

After selections have been made, a text field could appear to allow note entry. The supplied text would then be displayed within the highlighted area. I've mocked up what it could look like:

xDrip Span

It may be that another option is added to the Settings screen to show or hide the spanned notes, but I'd suggest that it might be best just to have them permanently on.

Hope this is of interest, and if so, I'd be happy to give the coding a go.

Regards,

Todd.

@m-a-v
Copy link

m-a-v commented May 9, 2024

Nightscout supports the entry of notes at a specific point in time. I also think that this is more practical for the display. Spike had supported such a feature and then synchronized the data with Nightscout.

@BrightScreenTV
Copy link
Author

Sorry, just to confirm: do you mean that it's more practical to leave any note recording to Nightscout or that specific points in time are more advantageous that spanned ones?

@m-a-v
Copy link

m-a-v commented May 9, 2024

Specific points in time will make interaction easier and also synchronization.

@BrightScreenTV
Copy link
Author

I think - if it were given the go ahead - it'd be a trivial matter of making the end of a spanned note, an option rather than a necessity. I feel there'd be minimal extra storage required to have an end data there.

The user could tap to enter a note and with little/no extra prompting also have an opportunity to mark the end-date of the note.

It's a good point you make, though: it never occurred to me that someone might be put off this feature because of the necessity to enter more parameters than they wanted to. Thanks.

@m-a-v
Copy link

m-a-v commented May 9, 2024

I feel this will make everything more complex: synchronization, interaction, etc. I don't see the advantage of having a span for an action. Only my 2 cents ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants