Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article Titles Open in New Tab Instead of Expanding #2

Closed
Wendigogo opened this issue Oct 17, 2024 · 7 comments
Closed

Article Titles Open in New Tab Instead of Expanding #2

Wendigogo opened this issue Oct 17, 2024 · 7 comments

Comments

@Wendigogo
Copy link

Wendigogo commented Oct 17, 2024

Describe the bug
When viewing the article stream, clicking on an article title should expand the article content below. However, I'm consistently experiencing an issue where clicking on the article title opens the article's origin website in a new tab.

To expand the article, I have to click on the timestamp located to the right of the article title.

I was able to expand articles as expected when I have disabled the extension.

To Reproduce

  1. Go to 'main stream' (or any label)
  2. Click on 'any article title'
  3. Observe that it has opened in a new tab to the 3rd party site as the hyperlink suggested

Expected behavior
The article should have expanded.

This is the exact same issue as christian-putzke#4 (that I copy-paste text 😅) so probably the solution is probably given there too (related commit : christian-putzke@9052884.

Thanks for your help.

@Wendigogo
Copy link
Author

Wendigogo commented Oct 17, 2024

I just grab V0.5 entry_header.phtml and entry_bottom.phtml from "Pocket Button" repository, search&replace pocket with readeck and replace related files with these on my server.

Problem solved !

I'm not familiar with Github so I attached correct files here: correct_entries.zip

I hope this helps.

@Joedmin
Copy link
Owner

Joedmin commented Oct 17, 2024

Hi, thank you very much for reporting this issue and it's fix. I'me getting on it right now to update it as soon as possible

@Joedmin
Copy link
Owner

Joedmin commented Oct 17, 2024

Fixed it and released Version 0.4

@Wendigogo
Copy link
Author

Wow, that was fast !

Do you think you could replicate your extension but for Wallabag APIs ? I opened an issue in FressRSS repository but no-one seems to care (FreshRSS/FreshRSS#6874)?

Readeck is (really) great but it lacks of a native app.

@Joedmin
Copy link
Owner

Joedmin commented Oct 17, 2024

Yeah sure, it's just using another API with the already existing code 😁

I know about the absence of the of native app for Readeck and I want to try to write it some day

@Wendigogo
Copy link
Author

I know about the absence of the absence of native app for Readeck and I want to try to write it some day

And this day, I'll switch from Wallabag to Readeck. ;)

@Joedmin
Copy link
Owner

Joedmin commented Oct 19, 2024

Wallabag Extension can be found here https://github.com/Joedmin/xExtension-wallabag-button 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants