From 8c0652ab01aebf945406b8d453d1ca50aa8c1d79 Mon Sep 17 00:00:00 2001 From: "Oleksandr.Karpovich" Date: Mon, 5 Aug 2024 12:43:50 +0200 Subject: [PATCH] Upd the comment in the tests --- .../src/commonTest/kotlin/org/jetbrains/skia/FontTests.kt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/skiko/src/commonTest/kotlin/org/jetbrains/skia/FontTests.kt b/skiko/src/commonTest/kotlin/org/jetbrains/skia/FontTests.kt index 415ee7a8b..691bc4205 100644 --- a/skiko/src/commonTest/kotlin/org/jetbrains/skia/FontTests.kt +++ b/skiko/src/commonTest/kotlin/org/jetbrains/skia/FontTests.kt @@ -133,11 +133,10 @@ class FontTests { } @Test - // Maybe it's a reason why this test fails with m122: - // https://github.com/google/skia/blob/main/RELEASE_NOTES.md#milestone-122 - // SkFont::getTypeface() will no longer return a nullptr to indicate "the default typeface". - // If left unspecified, SkFonts will use an empty typeface (e.g. no glyphs). fun emptyFontMetricsAreZero() { + // The behaviour was changed in m122. + // https://github.com/google/skia/blob/main/RELEASE_NOTES.md#milestone-122 + // There is no default font anymore. Font(Typeface.makeEmpty()).use { font -> val metrics = font.metrics assertTrue(