Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Republishing needed GrammarKit and IntelliJ dependencies as shadow Jar on MavenCentral #134

Open
hfhbd opened this issue May 14, 2023 · 0 comments

Comments

@hfhbd
Copy link
Contributor

hfhbd commented May 14, 2023

Is your feature request related to a problem? Please describe.
The code generation needs GrammarKit and some IntelliJ dependencies. These dependencies are only published on internal repos.
These repos are added by this plugin under the hood, if you don't use the new dependency resolution management #73 and #106.
If you use the new dependency resolution management, you have to add the IntelliJ repos too.

Describe the solution you'd like
Create a uber/fat/shadow jar containing all needed dependencies for the lexer and the parser and publish these dependencies at mavenCentral. Ideally, these dependencies are fine-tuned to only included needed deps, but no IntelliJ overhead (eg UI).

Describe alternatives you've considered
Keep the current state by also depending on the internal repos.

Additional context
We already did this in sqldelight, a sql compiler using the IntelliJ compiler apis, which makes the consumer usage way nicer: sqldelight/sqldelight#4079
Additionally, the Kotlin compiler uses this technique too, except it contains the shaded deps directly in the jar, this is the reason for the size of 56MB.

If you accept such change, I am open to create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant