Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New session is appended to existing one ignoring new session panels structure #260

Open
iromeo opened this issue Dec 18, 2023 · 2 comments
Assignees
Milestone

Comments

@iromeo
Copy link
Contributor

iromeo commented Dec 18, 2023

The new session is appended to existing one w/o panels. PR (https://github.com/JetBrains-Research/epigenome/pull/1530) adds panels serialization into Session file (#248).

If some tracks are already shown in JBR, JBR suggests appending a new session to the existing one. If the user accepts suggestion (press No) and allow to append his multi-panel session, all tracks will be added to the last panel. Seems better is to

  • If both sessions (existing and new) have only default panel - then keep current behaviour
  • If one of session is multi-panel, then add new session as addition panels after panels of existing session.

image

@iromeo iromeo added this to the JBR 2.0 milestone Dec 18, 2023
@Xewar313
Copy link

I am not entirely convinced if adding panels to the end of session is a good idea - let's assume that we have a session with 3 panels, and a second session with additional 3 panels. That would result in a session with 6 panels, and these panels would be quite small, and almost unusable.
Are you sure we want to implement it that way?

@iromeo
Copy link
Contributor Author

iromeo commented Dec 20, 2023

Agree, need to brainstorm a bit more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants