Rewrite scraper #41
Open
Rewrite scraper #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…napshot facility of CMC. Needs srape_hist()
… the coin retrieval e.g. gathered using a custom version of rypto_list().
…adapt much more tidyverse-notation.
…adapt much more tidyverse-notation.
…scraper_hist(). Output additional information on scraped data as attribute of crypto_history() (for backward compatibility). Merge branch 'master' of https://github.com/sstoeckl/crypto # Conflicts: # R/crypto_history.R
…scraper_hist(). Output additional information on scraped data as attribute of crypto_history() (for backward compatibility). Merge branch 'master' of https://github.com/sstoeckl/crypto # Conflicts: # R/crypto_history.R
…purrr's insistently() and safely() for scraping. Also, does first download all, the process data.
…ric (dead) currencies. Code now runs smoothely.
…of slugs. I just take them from the url of the historical snapshots.
…ck for empty tables in crypto_history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jesse, I have added to my previous modification by rewriting the crypto_history tool, so that it does not need the scraper.R any more. it takes full advantage of the possibilities of the tidyverse and the purrr package (possibly() with delay function and insistently()). However, the inclusion into your package will need some modifications to the rest of the package (delete superfluous functions etc which I have not made as the package works fine for me as is in this branch).
Best, Sebastian