Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jena integration – add support for content negotiation #136

Closed
1 task done
Ostrzyciel opened this issue Aug 24, 2024 · 4 comments · Fixed by #176
Closed
1 task done

Jena integration – add support for content negotiation #136

Ostrzyciel opened this issue Aug 24, 2024 · 4 comments · Fixed by #176
Assignees
@Ostrzyciel
Labels
enhancement New feature or request
Milestone
2.1.0

Comments

@Ostrzyciel
Copy link
Member

Ostrzyciel commented Aug 24, 2024 •
edited
Loading

I tried calling a SPARQL endpoint in Jena Fuseki with a CONSTRUCT query and the application/x-jelly-rdf media type, but it still returns the results in Turtle. There must be something missing in the registration there.

Probably the same applies to the graph store protocol. We should check this as well.

After adding this:
@Ostrzyciel Ostrzyciel added the bug Something isn't working label Aug 24, 2024
@Ostrzyciel Ostrzyciel added this to the 1.0.0 milestone Aug 24, 2024
@Ostrzyciel Ostrzyciel self-assigned this Sep 9, 2024
@Ostrzyciel Ostrzyciel modified the milestones: 1.0.0, 1.2.0 Sep 9, 2024
@Ostrzyciel
Copy link
Member Author

Looks like I can't implement this for now, as we are missing an interface for this in Fuseki. See: apache/jena#2700

Moving this to a future release.

@Ostrzyciel
Copy link
Member Author

You can get around this by adding an output=application/x-jelly-rdf parameter. Then it skips the entire content negotiation logic and forces Fuseki to use Jelly to serialize the response. Nice.

I will document this on the plugin doc page.

@Ostrzyciel Ostrzyciel changed the title Jena integration – content negotiation not working Jena integration – add support for content negotiation Sep 9, 2024
@Ostrzyciel Ostrzyciel added enhancement New feature or request and removed bug Something isn't working labels Sep 9, 2024
Ostrzyciel added a commit that referenced this issue Sep 9, 2024
@Ostrzyciel
Add note about unsupported conneg in Fuseki
d1550c6 
Issue: #136
@Ostrzyciel Ostrzyciel mentioned this issue Sep 9, 2024
Merged
Ostrzyciel added a commit that referenced this issue Sep 9, 2024
@Ostrzyciel
Add note about unsupported conneg in Fuseki (#142)
a864b65 
Issue: #136
@Ostrzyciel Ostrzyciel modified the milestones: 1.2.0, 1.1.0 Sep 10, 2024
@Ostrzyciel
Copy link
Member Author

The upstream patch got merged, so it should land in Jena 5.2.0. We should write this feature in such a way that it only loads only if Fuseki is loaded... preferably it should also do a Jena version check to make sure this new interface is available.

Let's wait for the 5.2.0 release.

@Ostrzyciel Ostrzyciel modified the milestones: 2.0.0, 2.1.0 Sep 17, 2024
@Ostrzyciel Ostrzyciel mentioned this issue Oct 10, 2024
Closed
@Ostrzyciel
Copy link
Member Author

There seems to be a bug in how the Fuseki webapp loads modules: apache/jena#2774

But we can still progress with this task. The functionality does work if you use the "Fuseki Main" distribution.

@Ostrzyciel Ostrzyciel linked a pull request Oct 15, 2024 that will close this issue
Jena integration – add support for content negotiation #176
Merged
@Ostrzyciel Ostrzyciel mentioned this issue Oct 15, 2024
Merged
Ostrzyciel added a commit that referenced this issue Oct 15, 2024
@Ostrzyciel
Move Fuseki integration to a Jena module
453099a 
Follow-up from #136

Fuseki modules are not supported in all Fuseki distributions, so it makes more sense to move the functionality to a Jena module. The only disadvantage is that the module loads regardless of whether we are in a Fuseki instance or not, but that can be solved with some exception catching...
@Ostrzyciel Ostrzyciel mentioned this issue Oct 15, 2024
Merged
Ostrzyciel added a commit that referenced this issue Oct 15, 2024
@Ostrzyciel
Move Fuseki integration to a Jena module (#179)
f5fad5f 
* Move Fuseki integration to a Jena module

Follow-up from #136

Fuseki modules are not supported in all Fuseki distributions, so it makes more sense to move the functionality to a Jena module. The only disadvantage is that the module loads regardless of whether we are in a Fuseki instance or not, but that can be solved with some exception catching...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ostrzyciel Ostrzyciel

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Jena integration – add support for content negotiation Jelly-RDF/jelly-jvm
1 participant
@Ostrzyciel