Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bash lib #7

Open
slominskir opened this issue Apr 1, 2024 · 0 comments
Open

Refactor bash lib #7

slominskir opened this issue Apr 1, 2024 · 0 comments

Comments

@slominskir
Copy link
Member

slominskir commented Apr 1, 2024

It may make sense to organize the bash library into a single file, possibly maintaining the ability to invoke a specific function. The bash script would then be both importable (source command) and executable. At the very least the following awkwardness should be resolved:

  1. The top of the files inconsistently do parameter checking. Sometimes parameters are required even if the function being called doesn't use them. Other times required params are missed because they are optional at the top of the file (but really are needed for the invoked function). Therefore parameter checking should be done per function (inside each function)
  2. If no specific function name is passed as an argument then a default set of functions are called. This becomes less and less useful and more confusing as the number of possible incompatible functions grow. For example, email configuration function is not needed for ATLis apps, and only one of either Oracle or MySQL functions should be chosen. This auto-execute default behavior should probably simply be dropped.
  3. There are some functions that are duplicated in multiple files such as wildfly_start_and_wait, wildfly_reload, and wildfly_stop.

Related: JeffersonLab/keycloak#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant