You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It may make sense to organize the bash library into a single file, possibly maintaining the ability to invoke a specific function. The bash script would then be both importable (source command) and executable. At the very least the following awkwardness should be resolved:
The top of the files inconsistently do parameter checking. Sometimes parameters are required even if the function being called doesn't use them. Other times required params are missed because they are optional at the top of the file (but really are needed for the invoked function). Therefore parameter checking should be done per function (inside each function)
If no specific function name is passed as an argument then a default set of functions are called. This becomes less and less useful and more confusing as the number of possible incompatible functions grow. For example, email configuration function is not needed for ATLis apps, and only one of either Oracle or MySQL functions should be chosen. This auto-execute default behavior should probably simply be dropped.
There are some functions that are duplicated in multiple files such as wildfly_start_and_wait, wildfly_reload, and wildfly_stop.
It may make sense to organize the bash library into a single file, possibly maintaining the ability to invoke a specific function. The bash script would then be both importable (source command) and executable. At the very least the following awkwardness should be resolved:
wildfly_start_and_wait
,wildfly_reload
, andwildfly_stop
.Related: JeffersonLab/keycloak#4
The text was updated successfully, but these errors were encountered: