-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: macOS rpath and dynamic library issues #73
Conversation
c-dilks
commented
Jan 5, 2024
•
edited
Loading
edited
- Add macOS CI tests, since many of our users work on macOS (though high-statistics processing will likely be on Linux machines).
- Fix python bindings don't work on macOS #75
- Fix macOS rpath is not defined correctly #71
BSD vs. Linux commands are going to make this fun... |
Successfully reproduced #71 https://github.com/JeffersonLab/iguana/actions/runs/7427660531/job/20213801254#step:11:9 |
Needed rpaths depend on platform:
Considering #23, but We may need to figure out how to set multiple rpath entries on macOS, since it appears to be different than Linux. However, no responses to mesonbuild/meson#5760 may mean multiple rpaths is not the right approach to solving this issue (and no, I don't want to force users to set |
Running |
I can't figure out how to get Python bindings to work on macOS, so disabling that test for now and deferring to #75 |
This reverts commit 779ea34.
Now resolved by this PR. |