Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macOS rpath and dynamic library issues #73

Merged
merged 45 commits into from
Jan 16, 2024
Merged

fix: macOS rpath and dynamic library issues #73

merged 45 commits into from
Jan 16, 2024

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Jan 5, 2024

@c-dilks
Copy link
Member Author

c-dilks commented Jan 5, 2024

BSD vs. Linux commands are going to make this fun...

@c-dilks
Copy link
Member Author

c-dilks commented Jan 5, 2024

@c-dilks
Copy link
Member Author

c-dilks commented Jan 6, 2024

Needed rpaths depend on platform:

  • on Linux, we need both hipo4 and iguana in the rpath
  • on macOS, we need just hipo4 (but bindings may need iguana, as indicated by the failing python test)

Considering #23, but iguana isn't the only consumer.

We may need to figure out how to set multiple rpath entries on macOS, since it appears to be different than Linux. However, no responses to mesonbuild/meson#5760 may mean multiple rpaths is not the right approach to solving this issue (and no, I don't want to force users to set $LD_LIBRARY_PATH or $DYLD_LIBRARYPATH).

@c-dilks
Copy link
Member Author

c-dilks commented Jan 8, 2024

We may need to figure out how to set multiple rpath entries on macOS, since it appears to be different than Linux.

Running install_name_tool -add_rpath post-installation on macOS executables is a workaround, but not a nice one. See cb14708

@c-dilks
Copy link
Member Author

c-dilks commented Jan 10, 2024

I can't figure out how to get Python bindings to work on macOS, so disabling that test for now and deferring to #75

@c-dilks c-dilks linked an issue Jan 12, 2024 that may be closed by this pull request
@c-dilks c-dilks linked an issue Jan 13, 2024 that may be closed by this pull request
3 tasks
@c-dilks c-dilks changed the title ci: test on MacOS fix: macOS rpath and dynamic library issues Jan 13, 2024
@c-dilks
Copy link
Member Author

c-dilks commented Jan 13, 2024

I can't figure out how to get Python bindings to work on macOS, so disabling that test for now and deferring to #75

Now resolved by this PR.

@c-dilks c-dilks merged commit ef8a57e into main Jan 16, 2024
26 checks passed
@c-dilks c-dilks deleted the ci-macos branch January 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python bindings don't work on macOS macOS rpath is not defined correctly
1 participant