Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: thread-safe configuration reload functions #258

Merged
merged 89 commits into from
Sep 26, 2024
Merged

feat: thread-safe configuration reload functions #258

merged 89 commits into from
Sep 26, 2024

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Jul 25, 2024 •
edited
Loading

resolves #95

@c-dilks c-dilks changed the title feat: use a thread pool for algorithm thread-safety testing feat: thread-safe configuration reload functions Jul 26, 2024
@c-dilks c-dilks linked an issue Jul 26, 2024 that may be closed by this pull request
provide a thread-safe way to reload configurations, for example, when the run number changes #95
Closed
@c-dilks c-dilks mentioned this pull request Jul 26, 2024
Closed
@c-dilks c-dilks deleted the branch main August 4, 2024 15:41
@c-dilks c-dilks closed this Aug 4, 2024
@c-dilks c-dilks reopened this Aug 4, 2024
@c-dilks c-dilks changed the base branch from BASE-rcdb to main August 4, 2024 15:43
@c-dilks c-dilks force-pushed the threadpool branch 2 times, most recently from a30b555 to 18ca118 Compare August 6, 2024 14:11
c-dilks added 19 commits September 9, 2024 11:55
@c-dilks
feat: use a thread pool for algorithm thread-safety testing
3525f97
@c-dilks
fix: reference thread-pool
a452ce9
@c-dilks
build: wrap oneTBB
f6da9b0
@c-dilks
fix: markdown syntax detection
3f0c376
@c-dilks
fix: fallback
4fb987a
@c-dilks
feat: ConcurrentParam
45c3924
@c-dilks
fix: add docstrings
ad15bf7
@c-dilks
refactor: split into header and source file
e7c3d46
@c-dilks
fix: template specializations
5859e5a
@c-dilks
fix: input bank
d0c22fe
@c-dilks
feat: handle other models in Reload
a3924d6
@c-dilks
refactor: use inheritance for concurrent parameter types
a7b1863
@c-dilks
fix: build errors
a12a2bf
@c-dilks
fix: documentation
c35fc68
@c-dilks
doc: improve
dceb18d
@c-dilks
fix: remove onetbb
11f467c
@c-dilks
fix: make option getters const, since now we have to
cca22aa
@c-dilks
fix: make memoize the unspoken default model
9508a42 
single-threaded users interested in optimizing will find `single` model
in the documentation, which may be a bit faster for them
@c-dilks
fix: update iguana_ex_cpp_config_files.cc
5d6292f
@c-dilks
fix: revert ZVertexFilter config, and choose slow variation for norma…
038ee1f 
…l tsan testing
@c-dilks
test: find the cause of gcovr failures; is it TestMultithreading.?
637e838 
since I'm unable to reproduce the failures locally
@c-dilks
test: TestMultithreading is the culprit; is setup okay?
e8da33e
@c-dilks
test: hipo::readerstream with trivial worker function
aefd5ce
@c-dilks
test: Start the algorithms
2b154d1
@c-dilks
test: just start and stop the algo
32aa891
@c-dilks
test: start and stop the sequence
9f93f5c
@c-dilks
fix: handle PID in ZVertexFilter
4b0f5c9
@c-dilks
test: limit to 1 thread
54364d5
@c-dilks
fix: workaround for gcovr issue
bfa8cb8
@c-dilks
ci: be sure to run all tests (in case we forget to add suites)
c71aa4c
@c-dilks
test: rebuild?
8fbd4ec
@c-dilks
fix: exclude TestMultithreading from gcovr
1c06918
@c-dilks
fix: revert TestMultithreading.h
405cd44
@c-dilks
fix: re-enable run number variation
18cae27
@c-dilks
test: one more attempt; maybe it's gcovr's problem...
63b356d
@c-dilks
test: GetCachedOption with wrong types
6686027
@c-dilks
fix: capture key by value (to avoid accidental mutation)
6ac62ef
@c-dilks
fix: error message
b193702
@c-dilks
doc: update config params for InclusiveKinematics
0a744d1
@c-dilks
doc: concurrency models
a263cbd
@c-dilks
fix: @returns
bbbb85a
@c-dilks c-dilks marked this pull request as ready for review September 26, 2024 15:08
@c-dilks
fix: remove GCOVR_EXCL* comments, which don't seem to solve the `gc…
a29c6df 
…ovr` problem
@c-dilks
fix: set concurrency model in C++ examples
decc968 
not bothering with Python examples yet, since we need to work on the
bindings...
@c-dilks
doc: some improvements
06c7294
@c-dilks c-dilks merged commit a107c98 into main Sep 26, 2024
44 of 45 checks passed
@c-dilks c-dilks deleted the threadpool branch September 26, 2024 16:17
@c-dilks c-dilks mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtysonCLAS12 rtysonCLAS12 Awaiting requested review from rtysonCLAS12 rtysonCLAS12 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Iguana
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide a thread-safe way to reload configurations, for example, when the run number changes
1 participant
@c-dilks