PhotonGBTFilter models #310
Comments
Instead, include them in the source file, so that the models don't need to be installed (they are just in the library). Closes #310
|
I chose a different approach in #311. Let me know if this works for you! |
|
@dglazier do you need this resolved before we tag iguana v0.8.0? |
|
@c-dilks currently I cannot test this until the various methods are public. |
|
Should I just make a branch and make the necessary changes to get it running in clas12root ? |
|
I'll send you an email with more details. This algorithm has no action functions yet, so clas12root's iguana wrapper cannot use it at the moment. |
|
You're welcome to make a testing branch/PR here, that's always welcome. |
|
It has a filter function which clas12root could use, https://github.com/dglazier/clas12root/blob/iguana_filter/iguana/Filters.h#L106 |
That is not an action function, despite the documentation; sorry for the misunderstanding here, I will correct the documentation. Its parameters do not meet specification. According to @Gregtom3, the author of this algorithm, defining a proper action function will take some refactoring. The Iguana user guide includes a list of the actual action functions; the bottom of this front page also details what an action function is, exactly. |
Instead, include them in the source file, so that the models don't need to be installed (they are just in the library). Closes #310
Instead, include them in the source file, so that the models don't need to be installed (they are just in the library). Closes #310
Instead, include them in the source file, so that the models don't need to be installed (they are just in the library). Closes #310
When trying to run this code with clas12root it needs the path to the models :
$IGUANA/src/iguana/algorithms/clas12/PhotonGBTFilter/
For #include "models/*"
Can these be copied to the iguana/include directory or something similar.
At the moment I can add the path with gInterpreter->AddIncludePath , but that assumes I can use $HIPO/../src/etc where $HIPO is the install directory and this is not garaunteed.
Cheers
Derek
The text was updated successfully, but these errors were encountered: