From 289adee73ea02f246695eff096e2d3abe4857b6a Mon Sep 17 00:00:00 2001 From: Christopher Dilks Date: Tue, 24 Sep 2024 19:50:17 -0400 Subject: [PATCH] refactor!: remove `ThreadPoolParam` --- .github/workflows/ci.yml | 4 +- doc/gen/Doxyfile.in | 1 - .../iguana_ex_fortran_01_action_functions.f | 5 +- src/iguana/algorithms/Algorithm.h | 3 +- src/iguana/algorithms/AlgorithmSequence.cc | 4 +- src/iguana/algorithms/AlgorithmSequence.h | 2 +- src/iguana/algorithms/Validator.h | 2 +- .../clas12/EventBuilderFilter/Algorithm.cc | 2 +- .../clas12/EventBuilderFilter/Algorithm.h | 2 +- .../clas12/FTEnergyCorrection/Algorithm.cc | 2 +- .../clas12/FTEnergyCorrection/Algorithm.h | 2 +- .../clas12/FiducialFilter/Algorithm.cc | 2 +- .../clas12/FiducialFilter/Algorithm.h | 2 +- .../clas12/FiducialFilter/Validator.cc | 4 +- .../clas12/FiducialFilter/Validator.h | 2 +- .../clas12/LorentzTransformer/Algorithm.cc | 2 +- .../clas12/LorentzTransformer/Algorithm.h | 2 +- .../clas12/MomentumCorrection/Algorithm.cc | 2 +- .../clas12/MomentumCorrection/Algorithm.h | 2 +- .../clas12/MomentumCorrection/Validator.cc | 4 +- .../clas12/MomentumCorrection/Validator.h | 2 +- .../clas12/PhotonGBTFilter/Algorithm.cc | 2 +- .../clas12/PhotonGBTFilter/Algorithm.h | 2 +- .../clas12/PhotonGBTFilter/Validator.cc | 4 +- .../clas12/PhotonGBTFilter/Validator.h | 2 +- .../clas12/SectorFinder/Algorithm.cc | 2 +- .../clas12/SectorFinder/Algorithm.h | 2 +- .../clas12/SectorFinder/Validator.cc | 4 +- .../clas12/SectorFinder/Validator.h | 2 +- .../clas12/ZVertexFilter/Action.yaml | 3 -- .../clas12/ZVertexFilter/Algorithm.cc | 15 +++--- .../clas12/ZVertexFilter/Algorithm.h | 5 +- .../clas12/ZVertexFilter/Validator.cc | 4 +- .../clas12/ZVertexFilter/Validator.h | 2 +- .../example/ExampleAlgorithm/Algorithm.cc | 2 +- .../example/ExampleAlgorithm/Algorithm.h | 2 +- .../physics/InclusiveKinematics/Action.yaml | 3 -- .../physics/InclusiveKinematics/Algorithm.cc | 15 +++--- .../physics/InclusiveKinematics/Algorithm.h | 5 +- .../physics/InclusiveKinematics/Validator.cc | 4 +- .../physics/InclusiveKinematics/Validator.h | 2 +- src/iguana/services/ConcurrentParam.cc | 51 +------------------ src/iguana/services/ConcurrentParam.h | 28 +--------- src/iguana/tests/iguana_test.cc | 3 +- src/iguana/tests/include/TestMultithreading.h | 4 +- src/iguana/tests/meson.build | 6 +-- 46 files changed, 71 insertions(+), 156 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 245dbea6..ef657121 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -408,10 +408,10 @@ jobs: - name: benchmark algorithms if: ${{ matrix.id == 'coverage' }} # use the coverage job's GITHUB_STEP_SUMMARY run: | - for suite in single_threaded memoize threadpool; do + for suite in single_threaded memoize; do meson test --benchmark --suite $suite -C iguana_build | tee benchmark_$suite.txt done - iguana_src/.github/make-benchmark-table.rb benchmark_{single_threaded,memoize,threadpool}.txt | xargs -0 -I{} echo {} >> $GITHUB_STEP_SUMMARY + iguana_src/.github/make-benchmark-table.rb benchmark_{single_threaded,memoize}.txt | xargs -0 -I{} echo {} >> $GITHUB_STEP_SUMMARY ### coverage - name: coverage if: ${{ matrix.id == 'coverage' }} diff --git a/doc/gen/Doxyfile.in b/doc/gen/Doxyfile.in index b81b8224..fad3d8d9 100644 --- a/doc/gen/Doxyfile.in +++ b/doc/gen/Doxyfile.in @@ -296,7 +296,6 @@ ALIASES += config_param{3|}="`\1``\2`\3" # action functions ALIASES += action_function{1}="\xrefitem action \"Function Type\" \"List of all Action Functions\" \1 \brief **Action Function:** " ALIASES += when_to_call{1}="@note This function should be called **\1**" -ALIASES += thread_id_desc="the thread index, if using `GlobalConcurrencyModel == \"threadpool\"`; otherwise, just use the default value" # examples ALIASES += begin_doc_example{1}="@addtogroup examples_\1^^@{" ALIASES += end_doc_example="@}" diff --git a/examples/iguana_ex_fortran_01_action_functions.f b/examples/iguana_ex_fortran_01_action_functions.f index 7bde2323..5e48021d 100644 --- a/examples/iguana_ex_fortran_01_action_functions.f +++ b/examples/iguana_ex_fortran_01_action_functions.f @@ -188,12 +188,11 @@ program iguana_ex_fortran_01_action_functions c before using the Z-vertext filter, we must "prepare" the c algorithm's configuration for this event; the resulting c 'key_vz_filter' must be passed to the action function; -c we leave the `thread_id` at zero (since we don't need it) call iguana_clas12_zvertexfilter_prepareevent( - & algo_vz_filter, runnum(1), 0, key_vz_filter) + & algo_vz_filter, runnum(1), key_vz_filter) c similarly for the inclusive kinematics algorithm call iguana_physics_inclusivekinematics_prepareevent( - & algo_inc_kin, runnum(1), 0, key_inc_kin) + & algo_inc_kin, runnum(1), key_inc_kin) c call iguana filters c - the `logical` variable `accept` must be initialized to diff --git a/src/iguana/algorithms/Algorithm.h b/src/iguana/algorithms/Algorithm.h index bc91cf84..7b540795 100644 --- a/src/iguana/algorithms/Algorithm.h +++ b/src/iguana/algorithms/Algorithm.h @@ -65,8 +65,7 @@ namespace iguana { /// @brief Run this algorithm for an event. /// @param banks the list of banks to process - /// @param thread_id @thread_id_desc - virtual void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const = 0; + virtual void Run(hipo::banklist& banks) const = 0; /// @brief Finalize this algorithm after all events are processed. virtual void Stop() = 0; diff --git a/src/iguana/algorithms/AlgorithmSequence.cc b/src/iguana/algorithms/AlgorithmSequence.cc index c8d3bd28..db75a9aa 100644 --- a/src/iguana/algorithms/AlgorithmSequence.cc +++ b/src/iguana/algorithms/AlgorithmSequence.cc @@ -9,10 +9,10 @@ namespace iguana { for(auto const& algo : m_sequence) algo->Start(banks); } - void AlgorithmSequence::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void AlgorithmSequence::Run(hipo::banklist& banks) const { for(auto const& algo : m_sequence) - algo->Run(banks, thread_id); + algo->Run(banks); } void AlgorithmSequence::Stop() { diff --git a/src/iguana/algorithms/AlgorithmSequence.h b/src/iguana/algorithms/AlgorithmSequence.h index a1f77580..5f620a75 100644 --- a/src/iguana/algorithms/AlgorithmSequence.h +++ b/src/iguana/algorithms/AlgorithmSequence.h @@ -16,7 +16,7 @@ namespace iguana { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; /// Create and add an algorithm to the sequence, by name. diff --git a/src/iguana/algorithms/Validator.h b/src/iguana/algorithms/Validator.h index db9ab74c..972cb834 100644 --- a/src/iguana/algorithms/Validator.h +++ b/src/iguana/algorithms/Validator.h @@ -27,7 +27,7 @@ namespace iguana { virtual ~Validator() {} void Start(hipo::banklist& banks) override{}; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override{}; + void Run(hipo::banklist& banks) const override{}; void Stop() override{}; /// Set this validator's output directory diff --git a/src/iguana/algorithms/clas12/EventBuilderFilter/Algorithm.cc b/src/iguana/algorithms/clas12/EventBuilderFilter/Algorithm.cc index c3d1bb5c..7d4fa5b8 100644 --- a/src/iguana/algorithms/clas12/EventBuilderFilter/Algorithm.cc +++ b/src/iguana/algorithms/clas12/EventBuilderFilter/Algorithm.cc @@ -16,7 +16,7 @@ namespace iguana::clas12 { } - void EventBuilderFilter::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void EventBuilderFilter::Run(hipo::banklist& banks) const { // get the banks diff --git a/src/iguana/algorithms/clas12/EventBuilderFilter/Algorithm.h b/src/iguana/algorithms/clas12/EventBuilderFilter/Algorithm.h index 401a00c8..dc65804c 100644 --- a/src/iguana/algorithms/clas12/EventBuilderFilter/Algorithm.h +++ b/src/iguana/algorithms/clas12/EventBuilderFilter/Algorithm.h @@ -22,7 +22,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; /// @action_function{scalar filter} checks if the PDG `pid` is a part of the list of user-specified PDGs diff --git a/src/iguana/algorithms/clas12/FTEnergyCorrection/Algorithm.cc b/src/iguana/algorithms/clas12/FTEnergyCorrection/Algorithm.cc index 0fcf135c..124c54b9 100644 --- a/src/iguana/algorithms/clas12/FTEnergyCorrection/Algorithm.cc +++ b/src/iguana/algorithms/clas12/FTEnergyCorrection/Algorithm.cc @@ -8,7 +8,7 @@ namespace iguana::clas12 { electron_mass = particle::mass.at(particle::electron); } - void FTEnergyCorrection::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const { + void FTEnergyCorrection::Run(hipo::banklist& banks) const { auto& ftParticleBank = GetBank(banks, b_ft_particle, "RECFT::Particle"); ShowBank(ftParticleBank, Logger::Header("INPUT FT PARTICLES")); for(auto const& row : ftParticleBank.getRowList()) { diff --git a/src/iguana/algorithms/clas12/FTEnergyCorrection/Algorithm.h b/src/iguana/algorithms/clas12/FTEnergyCorrection/Algorithm.h index f1673070..a768bf14 100644 --- a/src/iguana/algorithms/clas12/FTEnergyCorrection/Algorithm.h +++ b/src/iguana/algorithms/clas12/FTEnergyCorrection/Algorithm.h @@ -17,7 +17,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; /// @action_function{scalar transformer} diff --git a/src/iguana/algorithms/clas12/FiducialFilter/Algorithm.cc b/src/iguana/algorithms/clas12/FiducialFilter/Algorithm.cc index ee6aa625..a4ff7ec2 100644 --- a/src/iguana/algorithms/clas12/FiducialFilter/Algorithm.cc +++ b/src/iguana/algorithms/clas12/FiducialFilter/Algorithm.cc @@ -21,7 +21,7 @@ namespace iguana::clas12 { } -void FiducialFilter::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const { +void FiducialFilter::Run(hipo::banklist& banks) const { // get the banks auto& particleBank = GetBank(banks, b_particle, "REC::Particle"); auto& trajBank = GetBank(banks, b_traj, "REC::Traj"); diff --git a/src/iguana/algorithms/clas12/FiducialFilter/Algorithm.h b/src/iguana/algorithms/clas12/FiducialFilter/Algorithm.h index 59723442..35cd8863 100644 --- a/src/iguana/algorithms/clas12/FiducialFilter/Algorithm.h +++ b/src/iguana/algorithms/clas12/FiducialFilter/Algorithm.h @@ -22,7 +22,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; /// structure to hold `REC::Traj` data diff --git a/src/iguana/algorithms/clas12/FiducialFilter/Validator.cc b/src/iguana/algorithms/clas12/FiducialFilter/Validator.cc index 7a0c2e3b..8f93c89c 100644 --- a/src/iguana/algorithms/clas12/FiducialFilter/Validator.cc +++ b/src/iguana/algorithms/clas12/FiducialFilter/Validator.cc @@ -83,7 +83,7 @@ namespace iguana::clas12 { } - void FiducialFilterValidator::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void FiducialFilterValidator::Run(hipo::banklist& banks) const { // get the momenta before auto& particle_bank = GetBank(banks, b_particle, "REC::Particle"); @@ -104,7 +104,7 @@ namespace iguana::clas12 { } // run the fiducial cuts - m_algo_seq->Run(banks, thread_id); + m_algo_seq->Run(banks); // fill the plots for(auto const& row : particle_bank.getRowList()) { diff --git a/src/iguana/algorithms/clas12/FiducialFilter/Validator.h b/src/iguana/algorithms/clas12/FiducialFilter/Validator.h index 477c5957..cb97ab25 100644 --- a/src/iguana/algorithms/clas12/FiducialFilter/Validator.h +++ b/src/iguana/algorithms/clas12/FiducialFilter/Validator.h @@ -17,7 +17,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; private: diff --git a/src/iguana/algorithms/clas12/LorentzTransformer/Algorithm.cc b/src/iguana/algorithms/clas12/LorentzTransformer/Algorithm.cc index fdcbd9fa..f4091ef3 100644 --- a/src/iguana/algorithms/clas12/LorentzTransformer/Algorithm.cc +++ b/src/iguana/algorithms/clas12/LorentzTransformer/Algorithm.cc @@ -32,7 +32,7 @@ namespace iguana::clas12 { } - void LorentzTransformer::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void LorentzTransformer::Run(hipo::banklist& banks) const { auto& particleBank = GetBank(banks, b_particle, "REC::Particle"); diff --git a/src/iguana/algorithms/clas12/LorentzTransformer/Algorithm.h b/src/iguana/algorithms/clas12/LorentzTransformer/Algorithm.h index 38294299..8db5ce82 100644 --- a/src/iguana/algorithms/clas12/LorentzTransformer/Algorithm.h +++ b/src/iguana/algorithms/clas12/LorentzTransformer/Algorithm.h @@ -27,7 +27,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; /// @action_function{scalar transformer} boost the 4-momentum @f$p=(p_x,p_y,p_z,E)@f$ along @f$\beta=(\beta_x, \beta_y, \beta_z)@f$ diff --git a/src/iguana/algorithms/clas12/MomentumCorrection/Algorithm.cc b/src/iguana/algorithms/clas12/MomentumCorrection/Algorithm.cc index 47da0257..233eb6cf 100644 --- a/src/iguana/algorithms/clas12/MomentumCorrection/Algorithm.cc +++ b/src/iguana/algorithms/clas12/MomentumCorrection/Algorithm.cc @@ -13,7 +13,7 @@ namespace iguana::clas12 { } - void MomentumCorrection::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void MomentumCorrection::Run(hipo::banklist& banks) const { auto& particleBank = GetBank(banks, b_particle, "REC::Particle"); auto& sectorBank = GetBank(banks, b_sector, "REC::Particle::Sector"); diff --git a/src/iguana/algorithms/clas12/MomentumCorrection/Algorithm.h b/src/iguana/algorithms/clas12/MomentumCorrection/Algorithm.h index 9af37859..b7381192 100644 --- a/src/iguana/algorithms/clas12/MomentumCorrection/Algorithm.h +++ b/src/iguana/algorithms/clas12/MomentumCorrection/Algorithm.h @@ -20,7 +20,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; /// @action_function{scalar transformer} Apply the momentum correction diff --git a/src/iguana/algorithms/clas12/MomentumCorrection/Validator.cc b/src/iguana/algorithms/clas12/MomentumCorrection/Validator.cc index 0adbf343..810ce932 100644 --- a/src/iguana/algorithms/clas12/MomentumCorrection/Validator.cc +++ b/src/iguana/algorithms/clas12/MomentumCorrection/Validator.cc @@ -48,7 +48,7 @@ namespace iguana::clas12 { } - void MomentumCorrectionValidator::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void MomentumCorrectionValidator::Run(hipo::banklist& banks) const { // get the momenta before auto& particle_bank = GetBank(banks, b_particle, "REC::Particle"); @@ -61,7 +61,7 @@ namespace iguana::clas12 { particle_bank.getFloat("pz", row))); // run the momentum corrections - m_algo_seq->Run(banks, thread_id); + m_algo_seq->Run(banks); // lock the mutex, so we can mutate plots std::scoped_lock lock(m_mutex); diff --git a/src/iguana/algorithms/clas12/MomentumCorrection/Validator.h b/src/iguana/algorithms/clas12/MomentumCorrection/Validator.h index ab74be4c..8d5f685a 100644 --- a/src/iguana/algorithms/clas12/MomentumCorrection/Validator.h +++ b/src/iguana/algorithms/clas12/MomentumCorrection/Validator.h @@ -17,7 +17,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; private: diff --git a/src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.cc b/src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.cc index ef1b70c9..ec1a40e4 100644 --- a/src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.cc +++ b/src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.cc @@ -18,7 +18,7 @@ namespace iguana::clas12 { - void PhotonGBTFilter::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void PhotonGBTFilter::Run(hipo::banklist& banks) const { auto& particleBank = GetBank(banks, b_particle, "REC::Particle"); diff --git a/src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.h b/src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.h index 9aafb57f..08f2033d 100644 --- a/src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.h +++ b/src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.h @@ -34,7 +34,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; /// **Method**: Applies forward detector cut using REC::Particle Theta diff --git a/src/iguana/algorithms/clas12/PhotonGBTFilter/Validator.cc b/src/iguana/algorithms/clas12/PhotonGBTFilter/Validator.cc index efe63954..001af21b 100644 --- a/src/iguana/algorithms/clas12/PhotonGBTFilter/Validator.cc +++ b/src/iguana/algorithms/clas12/PhotonGBTFilter/Validator.cc @@ -26,7 +26,7 @@ namespace iguana::clas12 { InitializeHistograms(); } - void PhotonGBTFilterValidator::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void PhotonGBTFilterValidator::Run(hipo::banklist& banks) const { // get the particle bank auto& particle_bank = GetBank(banks, b_particle, "REC::Particle"); @@ -45,7 +45,7 @@ namespace iguana::clas12 { } // run the photon filter - m_algo_seq->Run(banks, thread_id); + m_algo_seq->Run(banks); std::vector filtered_photons; for(auto const& row : particle_bank.getRowList()) { diff --git a/src/iguana/algorithms/clas12/PhotonGBTFilter/Validator.h b/src/iguana/algorithms/clas12/PhotonGBTFilter/Validator.h index eb8e4bfd..fc84ff8e 100644 --- a/src/iguana/algorithms/clas12/PhotonGBTFilter/Validator.h +++ b/src/iguana/algorithms/clas12/PhotonGBTFilter/Validator.h @@ -19,7 +19,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; private: diff --git a/src/iguana/algorithms/clas12/SectorFinder/Algorithm.cc b/src/iguana/algorithms/clas12/SectorFinder/Algorithm.cc index b0eb2dde..05a3f864 100644 --- a/src/iguana/algorithms/clas12/SectorFinder/Algorithm.cc +++ b/src/iguana/algorithms/clas12/SectorFinder/Algorithm.cc @@ -49,7 +49,7 @@ namespace iguana::clas12 { i_pindex = result_schema.getEntryOrder("pindex"); } - void SectorFinder::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void SectorFinder::Run(hipo::banklist& banks) const { auto& particleBank = GetBank(banks, b_particle, "REC::Particle"); auto& resultBank = GetBank(banks, b_result, "REC::Particle::Sector"); diff --git a/src/iguana/algorithms/clas12/SectorFinder/Algorithm.h b/src/iguana/algorithms/clas12/SectorFinder/Algorithm.h index 6d9fe4be..f1766afa 100644 --- a/src/iguana/algorithms/clas12/SectorFinder/Algorithm.h +++ b/src/iguana/algorithms/clas12/SectorFinder/Algorithm.h @@ -22,7 +22,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; /// @action_function{vector creator} for a given particle with index `pindex`, get its sector from a detector bank's list of `sectors` and `pindices` (both must be ordered in the same way); diff --git a/src/iguana/algorithms/clas12/SectorFinder/Validator.cc b/src/iguana/algorithms/clas12/SectorFinder/Validator.cc index 702177eb..b024e4a6 100644 --- a/src/iguana/algorithms/clas12/SectorFinder/Validator.cc +++ b/src/iguana/algorithms/clas12/SectorFinder/Validator.cc @@ -54,7 +54,7 @@ namespace iguana::clas12 { } - void SectorFinderValidator::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void SectorFinderValidator::Run(hipo::banklist& banks) const { auto& particle_bank = GetBank(banks, b_particle, "REC::Particle"); @@ -62,7 +62,7 @@ namespace iguana::clas12 { auto& cal_bank = GetBank(banks, b_cal, "REC::Calorimeter"); - m_algo_seq->Run(banks, thread_id); + m_algo_seq->Run(banks); // lock the mutex, so we can mutate plots std::scoped_lock lock(m_mutex); diff --git a/src/iguana/algorithms/clas12/SectorFinder/Validator.h b/src/iguana/algorithms/clas12/SectorFinder/Validator.h index 8ecd080f..4b4763af 100644 --- a/src/iguana/algorithms/clas12/SectorFinder/Validator.h +++ b/src/iguana/algorithms/clas12/SectorFinder/Validator.h @@ -18,7 +18,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; private: diff --git a/src/iguana/algorithms/clas12/ZVertexFilter/Action.yaml b/src/iguana/algorithms/clas12/ZVertexFilter/Action.yaml index d4c91c0c..ad1d2061 100644 --- a/src/iguana/algorithms/clas12/ZVertexFilter/Action.yaml +++ b/src/iguana/algorithms/clas12/ZVertexFilter/Action.yaml @@ -7,9 +7,6 @@ actions: inputs: - name: runnum type: int - - name: thread_id - type: concurrent_key_t - cast: int outputs: - type: concurrent_key_t cast: int diff --git a/src/iguana/algorithms/clas12/ZVertexFilter/Algorithm.cc b/src/iguana/algorithms/clas12/ZVertexFilter/Algorithm.cc index d17e70ee..dda42173 100644 --- a/src/iguana/algorithms/clas12/ZVertexFilter/Algorithm.cc +++ b/src/iguana/algorithms/clas12/ZVertexFilter/Algorithm.cc @@ -17,7 +17,7 @@ namespace iguana::clas12 { b_config = GetBankIndex(banks, "RUN::config"); } - void ZVertexFilter::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void ZVertexFilter::Run(hipo::banklist& banks) const { // get the banks @@ -28,7 +28,7 @@ namespace iguana::clas12 { ShowBank(particleBank, Logger::Header("INPUT PARTICLES")); // prepare the event, reloading configuration parameters, if necessary - auto key = PrepareEvent(configBank.getInt("run", 0), thread_id); + auto key = PrepareEvent(configBank.getInt("run", 0)); // filter the input bank for requested PDG code(s) particleBank.getMutableRowList().filter([this, &key](auto bank, auto row) { @@ -44,18 +44,19 @@ namespace iguana::clas12 { ShowBank(particleBank, Logger::Header("OUTPUT PARTICLES")); } - concurrent_key_t ZVertexFilter::PrepareEvent(int const runnum, concurrent_key_t thread_id) const { - m_log->Trace("calling PrepareEvent({}, {})", runnum, thread_id); + concurrent_key_t ZVertexFilter::PrepareEvent(int const runnum) const { + m_log->Trace("calling PrepareEvent({})", runnum); if(o_runnum->NeedsHashing()) { std::hash hash_ftn; auto hash_key = hash_ftn(runnum); if(!o_runnum->HasKey(hash_key)) Reload(runnum, hash_key); return hash_key; + } else { + if(o_runnum->IsEmpty() || o_runnum->Load(0) != runnum) + Reload(runnum, 0); + return 0; } - if(o_runnum->IsEmpty() || o_runnum->Load(thread_id) != runnum) - Reload(runnum, thread_id); - return thread_id; } void ZVertexFilter::Reload(int const runnum, concurrent_key_t key) const { diff --git a/src/iguana/algorithms/clas12/ZVertexFilter/Algorithm.h b/src/iguana/algorithms/clas12/ZVertexFilter/Algorithm.h index 5d5e4e42..ddea6da5 100644 --- a/src/iguana/algorithms/clas12/ZVertexFilter/Algorithm.h +++ b/src/iguana/algorithms/clas12/ZVertexFilter/Algorithm.h @@ -23,15 +23,14 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; /// @action_function{reload} prepare the event /// @when_to_call{for each event} /// @param runnum the run number - /// @param thread_id @thread_id_desc /// @returns the key to be used in `::Filter` - concurrent_key_t PrepareEvent(int const runnum, concurrent_key_t thread_id = 0) const; + concurrent_key_t PrepareEvent(int const runnum) const; /// @action_function{scalar filter} checks if the Z Vertex is within specified bounds if pid is one for which the filter should be applied to.; /// Cuts applied to particles in FD or CD (ie not in FT). diff --git a/src/iguana/algorithms/clas12/ZVertexFilter/Validator.cc b/src/iguana/algorithms/clas12/ZVertexFilter/Validator.cc index 68e1c400..c22e2d44 100644 --- a/src/iguana/algorithms/clas12/ZVertexFilter/Validator.cc +++ b/src/iguana/algorithms/clas12/ZVertexFilter/Validator.cc @@ -49,7 +49,7 @@ namespace iguana::clas12 { } - void ZVertexFilterValidator::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void ZVertexFilterValidator::Run(hipo::banklist& banks) const { auto& particle_bank = GetBank(banks, b_particle, "REC::Particle"); @@ -69,7 +69,7 @@ namespace iguana::clas12 { } // run the momentum corrections - m_algo_seq->Run(banks, thread_id); + m_algo_seq->Run(banks); // fill the plots after for(auto const& row : particle_bank.getRowList()) { diff --git a/src/iguana/algorithms/clas12/ZVertexFilter/Validator.h b/src/iguana/algorithms/clas12/ZVertexFilter/Validator.h index 4e398632..a846a48f 100644 --- a/src/iguana/algorithms/clas12/ZVertexFilter/Validator.h +++ b/src/iguana/algorithms/clas12/ZVertexFilter/Validator.h @@ -16,7 +16,7 @@ namespace iguana::clas12 { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; private: diff --git a/src/iguana/algorithms/example/ExampleAlgorithm/Algorithm.cc b/src/iguana/algorithms/example/ExampleAlgorithm/Algorithm.cc index 14dff7ff..bab21861 100644 --- a/src/iguana/algorithms/example/ExampleAlgorithm/Algorithm.cc +++ b/src/iguana/algorithms/example/ExampleAlgorithm/Algorithm.cc @@ -59,7 +59,7 @@ namespace iguana::example { // # - try to avoid expensive operations here; instead, put them in the `Start` method // # if it is reasonable to do so // ############################################################################ - void ExampleAlgorithm::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void ExampleAlgorithm::Run(hipo::banklist& banks) const { // ############################################################################ // # get the banks; here we just need `REC::Particle` diff --git a/src/iguana/algorithms/example/ExampleAlgorithm/Algorithm.h b/src/iguana/algorithms/example/ExampleAlgorithm/Algorithm.h index 6e4ac903..90750d40 100644 --- a/src/iguana/algorithms/example/ExampleAlgorithm/Algorithm.h +++ b/src/iguana/algorithms/example/ExampleAlgorithm/Algorithm.h @@ -63,7 +63,7 @@ namespace iguana::example { // # - each algorithm must have these methods (even if they do nothing) // ############################################################################ void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; // ############################################################################ diff --git a/src/iguana/algorithms/physics/InclusiveKinematics/Action.yaml b/src/iguana/algorithms/physics/InclusiveKinematics/Action.yaml index 45dfe2c1..fe2e2e4d 100644 --- a/src/iguana/algorithms/physics/InclusiveKinematics/Action.yaml +++ b/src/iguana/algorithms/physics/InclusiveKinematics/Action.yaml @@ -7,9 +7,6 @@ actions: inputs: - name: runnum type: int - - name: thread_id - type: concurrent_key_t - cast: int outputs: - type: concurrent_key_t cast: int diff --git a/src/iguana/algorithms/physics/InclusiveKinematics/Algorithm.cc b/src/iguana/algorithms/physics/InclusiveKinematics/Algorithm.cc index 5cf433a6..0b33d1d9 100644 --- a/src/iguana/algorithms/physics/InclusiveKinematics/Algorithm.cc +++ b/src/iguana/algorithms/physics/InclusiveKinematics/Algorithm.cc @@ -76,14 +76,14 @@ namespace iguana::physics { /////////////////////////////////////////////////////////////////////////////// - void InclusiveKinematics::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void InclusiveKinematics::Run(hipo::banklist& banks) const { auto& particle_bank = GetBank(banks, b_particle, "REC::Particle"); auto& config_bank = GetBank(banks, b_config, "RUN::config"); auto& result_bank = GetBank(banks, b_result, GetClassName()); ShowBank(particle_bank, Logger::Header("INPUT PARTICLES")); - auto key = PrepareEvent(config_bank.getInt("run",0), thread_id); + auto key = PrepareEvent(config_bank.getInt("run",0)); auto lepton_pindex = FindScatteredLepton(particle_bank, key); if(lepton_pindex < 0) { @@ -152,19 +152,20 @@ namespace iguana::physics { /////////////////////////////////////////////////////////////////////////////// - concurrent_key_t InclusiveKinematics::PrepareEvent(int const runnum, concurrent_key_t thread_id) const + concurrent_key_t InclusiveKinematics::PrepareEvent(int const runnum) const { - m_log->Trace("calling PrepareEvent({}, {})", runnum, thread_id); + m_log->Trace("calling PrepareEvent({})", runnum); if(o_runnum->NeedsHashing()) { std::hash hash_ftn; auto hash_key = hash_ftn(runnum); if(!o_runnum->HasKey(hash_key)) Reload(runnum, hash_key); return hash_key; + } else { + if(o_runnum->IsEmpty() || o_runnum->Load(0) != runnum) + Reload(runnum, 0); + return 0; } - if(o_runnum->IsEmpty() || o_runnum->Load(thread_id) != runnum) - Reload(runnum, thread_id); - return thread_id; } /////////////////////////////////////////////////////////////////////////////// diff --git a/src/iguana/algorithms/physics/InclusiveKinematics/Algorithm.h b/src/iguana/algorithms/physics/InclusiveKinematics/Algorithm.h index 7d91ae43..ea5edab5 100644 --- a/src/iguana/algorithms/physics/InclusiveKinematics/Algorithm.h +++ b/src/iguana/algorithms/physics/InclusiveKinematics/Algorithm.h @@ -47,15 +47,14 @@ namespace iguana::physics { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; /// @action_function{reload} prepare the event /// @when_to_call{for each event} /// @param runnum the run number - /// @param thread_id @thread_id_desc /// @returns the key to be used in `::ComputeFromLepton` - concurrent_key_t PrepareEvent(int const runnum, concurrent_key_t thread_id = 0) const; + concurrent_key_t PrepareEvent(int const runnum) const; /// @action_function{scalar creator} compute kinematics from the scattered lepton. /// @param lepton_px scattered lepton momentum component @f$p_x@f$ (GeV) diff --git a/src/iguana/algorithms/physics/InclusiveKinematics/Validator.cc b/src/iguana/algorithms/physics/InclusiveKinematics/Validator.cc index fc118d56..45a8e1c4 100644 --- a/src/iguana/algorithms/physics/InclusiveKinematics/Validator.cc +++ b/src/iguana/algorithms/physics/InclusiveKinematics/Validator.cc @@ -52,10 +52,10 @@ namespace iguana::physics { } - void InclusiveKinematicsValidator::Run(hipo::banklist& banks, concurrent_key_t const thread_id) const + void InclusiveKinematicsValidator::Run(hipo::banklist& banks) const { // calculate kinematics - m_algo_seq->Run(banks, thread_id); + m_algo_seq->Run(banks); auto& particle_bank = GetBank(banks, b_particle, "REC::Particle"); auto& result_bank = GetBank(banks, b_result, "physics::InclusiveKinematics"); diff --git a/src/iguana/algorithms/physics/InclusiveKinematics/Validator.h b/src/iguana/algorithms/physics/InclusiveKinematics/Validator.h index f3d0b4e8..f5550cf3 100644 --- a/src/iguana/algorithms/physics/InclusiveKinematics/Validator.h +++ b/src/iguana/algorithms/physics/InclusiveKinematics/Validator.h @@ -18,7 +18,7 @@ namespace iguana::physics { public: void Start(hipo::banklist& banks) override; - void Run(hipo::banklist& banks, concurrent_key_t const thread_id = 0) const override; + void Run(hipo::banklist& banks) const override; void Stop() override; private: diff --git a/src/iguana/services/ConcurrentParam.cc b/src/iguana/services/ConcurrentParam.cc index 519b989f..80ac933d 100644 --- a/src/iguana/services/ConcurrentParam.cc +++ b/src/iguana/services/ConcurrentParam.cc @@ -27,12 +27,6 @@ namespace iguana { this->m_needs_hashing = true; } - template - ThreadPoolParam::ThreadPoolParam() : ConcurrentParam("threadpool") - { - this->m_needs_hashing = false; - } - // ================================================================================== // Load methods // ================================================================================== @@ -51,17 +45,6 @@ namespace iguana { throw std::runtime_error("MemoizedParam::Load failed to find the parameter"); } - template - T const ThreadPoolParam::Load(concurrent_key_t const key) const - { - try { - return m_container.at(key); - } - catch(std::out_of_range const& ex) { - throw std::runtime_error("ThreadPoolParam::Load failed to find the parameter"); - } - } - // ================================================================================== // Save methods // ================================================================================== @@ -81,19 +64,6 @@ namespace iguana { m_container.insert({key, value}); } - template - void ThreadPoolParam::Save(T const& value, concurrent_key_t const key) - { - std::lock_guard const lock(this->m_mutex); - this->m_empty = false; - while(key >= m_container.size()) { - m_container.push_back({}); // allocate space... - if(m_container.size() > 256) // ...but not too much - throw std::runtime_error("ThreadPoolParam::Save allocated a very large array; if you really need such a large threadpool, contact the developers"); - } - m_container[key] = value; - } - // ================================================================================== // HasKey methods // ================================================================================== @@ -101,7 +71,7 @@ namespace iguana { template bool SingleThreadParam::HasKey(concurrent_key_t const key) const { - throw std::runtime_error("do not call ConcurrentParam::HasKey when model is 'none'"); + throw std::runtime_error("do not call ConcurrentParam::HasKey when model is 'single'"); } template @@ -110,12 +80,6 @@ namespace iguana { return m_container.find(key) != m_container.end(); } - template - bool ThreadPoolParam::HasKey(concurrent_key_t const key) const - { - throw std::runtime_error("do not call ConcurrentParam::HasKey when model is 'threadpool'"); - } - // ================================================================================== // GetSize() methods // ================================================================================== @@ -131,12 +95,6 @@ namespace iguana { return m_container.size(); } - template - std::size_t ThreadPoolParam::GetSize() const - { - return m_container.size(); - } - // ================================================================================== // template specializations // ================================================================================== @@ -162,11 +120,4 @@ namespace iguana { template class MemoizedParam>; template class MemoizedParam>; - template class ThreadPoolParam; - template class ThreadPoolParam; - template class ThreadPoolParam; - template class ThreadPoolParam>; - template class ThreadPoolParam>; - template class ThreadPoolParam>; - } diff --git a/src/iguana/services/ConcurrentParam.h b/src/iguana/services/ConcurrentParam.h index 0017f086..d4a8a23e 100644 --- a/src/iguana/services/ConcurrentParam.h +++ b/src/iguana/services/ConcurrentParam.h @@ -101,30 +101,6 @@ namespace iguana { }; - // ================================================================================== - // ThreadPoolParam - // ================================================================================== - - /// @brief a `ConcurrentParam` that uses unique thread-pool indices for thread safety - template - class ThreadPoolParam : public ConcurrentParam { - - /// hash table container for memoization - using container_t = std::vector; - - public: - ThreadPoolParam(); - ~ThreadPoolParam() override = default; - T const Load(concurrent_key_t const key) const override; - void Save(T const& value, concurrent_key_t const key) override; - bool HasKey(concurrent_key_t const key) const override; - std::size_t GetSize() const override; - - private: - container_t m_container; - - }; - // ================================================================================== // ConcurrentParamFactory // ================================================================================== @@ -147,10 +123,8 @@ namespace iguana { return std::make_unique>(); else if(GlobalConcurrencyModel() == "memoize") return std::make_unique>(); - else if(GlobalConcurrencyModel() == "threadpool") - return std::make_unique>(); - throw std::runtime_error("unknown GlobalConcurrencyModel '" + GlobalConcurrencyModel() + "'"); + throw std::runtime_error("unknown GlobalConcurrencyModel '" + GlobalConcurrencyModel() + "'; valid options are 'single' or 'memoize'"); } }; diff --git a/src/iguana/tests/iguana_test.cc b/src/iguana/tests/iguana_test.cc index b16f6a8f..cad9a6c4 100644 --- a/src/iguana/tests/iguana_test.cc +++ b/src/iguana/tests/iguana_test.cc @@ -99,8 +99,7 @@ int main(int argc, char** argv) {"m", [&]() { fmt::print(" {:<20} {}\n", "-m CONCURRENCY_MODEL", "concurrency model"); - fmt::print(" {:<20} 'single', 'memoize', or 'threadpool'\n", ""); - fmt::print(" {:<20} default: use the internal default\n", ""); + fmt::print(" {:<20} 'memoize' is currently the only option\n", ""); }}, {"V", [&]() { diff --git a/src/iguana/tests/include/TestMultithreading.h b/src/iguana/tests/include/TestMultithreading.h index acc2ff68..4ebe6ede 100644 --- a/src/iguana/tests/include/TestMultithreading.h +++ b/src/iguana/tests/include/TestMultithreading.h @@ -119,7 +119,7 @@ inline int TestMultithreading( // occasionally vary the run number (if the user wants to) if(run_config_bank_idx.has_value()) - banks[run_config_bank_idx.value()].putInt("run", 0, std::rand() % 3000); + banks[run_config_bank_idx.value()].putInt("run", 0, std::rand() % 3000); // rapid variation test // FIXME: revert this // if(vary_run && run_config_bank_idx.has_value()) { // if(std::rand() % 10 == 0) { // auto runnum = banks[run_config_bank_idx.value()].getInt("run", 0); @@ -132,7 +132,7 @@ inline int TestMultithreading( // } // run the iguana algorithm - seq.Run(banks, order); + seq.Run(banks); } } if(nNonEmpty == 0) diff --git a/src/iguana/tests/meson.build b/src/iguana/tests/meson.build index a50db855..e086ee3a 100644 --- a/src/iguana/tests/meson.build +++ b/src/iguana/tests/meson.build @@ -57,7 +57,7 @@ foreach algo : algo_dict ) # multithreaded tests - foreach concurrency_model : [ 'memoize', 'threadpool' ] + foreach concurrency_model : [ 'memoize' ] # note: we used to have more, so leave this array in case we want more multithreading_args = [ 'multithreading', '-j', get_option('test_multithreading').to_string(), @@ -67,7 +67,7 @@ foreach algo : algo_dict test( '-'.join(['multithreading', concurrency_model, test_name_algo]), test_exe, - suite: [ 'multithreading', concurrency_model ], + suite: [ 'algorithm', 'multithreading', concurrency_model ], args: multithreading_args + [ '-n', get_option('test_num_events') ] + test_args, is_parallel: false, env: project_test_env, @@ -76,7 +76,7 @@ foreach algo : algo_dict benchmark( '-'.join(['benchmark', f'multithreading_@concurrency_model@', test_name_algo]), test_exe, - suite: [ 'multithreading', concurrency_model ], + suite: [ 'algorithm', 'multithreading', concurrency_model ], args: multithreading_args + [ '-n', '0' ] + test_args, # benchmark all the events env: project_test_env, timeout: 0,