Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSAN complaint about lock-order inversion #370

Closed
nathanwbrei opened this issue Oct 10, 2024 · 1 comment
Closed

TSAN complaint about lock-order inversion #370

nathanwbrei opened this issue Oct 10, 2024 · 1 comment

Comments

@nathanwbrei
Copy link
Collaborator

TSAN complains about a lock-order inversion. In one place we already have the scheduler lock, and we acquire the event source lock. In another place we have the event source lock, and acquire the scheduler lock. Usually a cycle in the lock acquisition graph indicates potential for deadlock. I'm not too concerned about this particular case because it is only triggered when the user presses Ctrl-C, and even if it does deadlock, they can always Ctrl-C a second time to hard-exit. However, we might be redesigning the event source locking for the sake of performance optimization anyhow, and if we do, we should fix this then.

warnings.txt

@nathanwbrei
Copy link
Collaborator Author

Lock-order inversion is gone as of #385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant