Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up jana-config.h #265

Closed
nathanwbrei opened this issue Nov 21, 2023 · 1 comment
Closed

Clean up jana-config.h #265

nathanwbrei opened this issue Nov 21, 2023 · 1 comment

Comments

@nathanwbrei
Copy link
Collaborator

jana-config.h captures a bunch of preprocessor defines and ensures that downstream code sees the same values that libJANA was compiled with. However, it has a bunch of inconsistencies, and it isn't trivial to resolve them because of how they tie in with halld_recon. Meanwhile, we have other, similar preprocessor defines (most notably JANA2_HAVE_PODIO) which are exported as part of the CMake target instead of being baked into jana-config.h.

There is a great conversation about what to do about all of this over in PR #264. However, I would like to merge that PR now and worry about this issue later.

@nathanwbrei
Copy link
Collaborator Author

This issue is fully addressed by PR #313. jana_config.h no longer exists, and the preprocessor defines JANA2_HAVE_{ROOT,Podio,Xerces} are all set exactly once in JVersion.h and the user can't modify them after compilation. Also note that these used to be a mixture of #ifs and #ifdefs. Now they are all uniformly #if because we are creating a closed world assumption for JANA2's compilation options. (Think spack, not autoconf!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant