Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding several acquisition functions #459

Open
1 of 4 tasks
miguelgondu opened this issue Jul 8, 2024 · 1 comment
Open
1 of 4 tasks

feat: Adding several acquisition functions #459

miguelgondu opened this issue Jul 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@miguelgondu
Copy link
Contributor

miguelgondu commented Jul 8, 2024

Adding several acquisition functions

Currently we have Thompson Sampling and Probability of Improvement as acquisition functions. It would be ideal to include

  • Expected Improvement (EI).
  • Upper Confidence Bound (UCB).
  • Log-Probability of Improvement (logPI).
  • Log-Expected Improvement (logEI).

Describe Preferred Solution

These acquisition functions could naturally fit inside the decision making module. GPJax already has the core ingredients for e.g. acquisition function maximization using L-BFGS, and BO loops using utility-driven decision making.

Additional Context

Here are some relevant references we could use for implementing these acquisition functions:

If the feature request is approved, would you be willing to submit a PR?

Yes, I am glad to contribute implementations of e.g. UCB and logEI.

@miguelgondu miguelgondu added the enhancement New feature or request label Jul 8, 2024
@miguelgondu miguelgondu changed the title Feature: Adding several acquisition functions feat: Adding several acquisition functions Jul 8, 2024
@daniel-dodd
Copy link
Member

Thanks @miguelgondu - this would make an excellent contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants