Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing JARs for 1.4.x in official Maven Repos #339

Closed
markieww opened this issue Aug 3, 2020 · 7 comments
Closed

Missing JARs for 1.4.x in official Maven Repos #339

markieww opened this issue Aug 3, 2020 · 7 comments
Labels

Comments

@keilw keilw added the invalid label Aug 3, 2020
@keilw
Copy link
Member

keilw commented Aug 3, 2020

Yes that's exactly how it's supposed to be. Every version since 1.3 Moneta has been modular and you need to use it as a "BOM", see https://github.com/JavaMoney/javamoney-examples/blob/master/console/javamoney-console-simple/pom.xml or the README in this repo.

@keilw keilw closed this as completed Aug 3, 2020
@ToppScorer
Copy link

ToppScorer commented Nov 21, 2022

Sorry, but this can not be used, how a BOM is supposed to be used. When importing the BOM

<dependencyManagement>
    <dependency>
      <groupId>org.javamoney</groupId>
      <artifactId>moneta</artifactId>
      <version>1.4.2</version>
      <type>pom</type>
      <scope>import</scope>
    </dependency>
</dependencyManagement>

you should be able to import the artifacts without using the version number:

<dependency>
  <groupId>org.javamoney</groupId>
  <artifactId>moneta-core</artifactId>
</dependency>

but this is not possible, as the groupId is not the same.

If you try to use:

<dependency>
  <groupId>org.javamoney.moneta</groupId>
  <artifactId>moneta-core</artifactId>
</dependency>

the version is missing from the dependency.

@keilw
Copy link
Member

keilw commented Nov 21, 2022

As this is the Moneta Parent POM the version number in dependency management is totally fine.

@ToppScorer
Copy link

Not sure what you mean by this. How is you "BOM" supposed to be used? Can you give an example where only the moneta-core module would be included in a project?

@keilw
Copy link
Member

keilw commented Nov 21, 2022

@ToppScorer
Copy link

I think the problem is, that your "BOM" already defines dependencies and not only versions, what BOMs should only do.

@keilw
Copy link
Member

keilw commented Nov 21, 2022

Well somewhere you must define them, otherwise you won't find any, but defining a "BOM" is up to you, the examples work the way they are.
The top level POM of examples uses dependencyManagement (in a BOM-like style) while individual modules use it.
However, the version of Moneta is usually declared in the individual modules only and not from the parent because they may differ, especially the "backport" (which will be phased out soon) had a separate dependency and other modules may also use different versions if they like.

If you feel the need or would like to contribute to a true "BOM", see this very old ticket: JavaMoney/javamoney-parent#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants