Installing an extension that defines extra types results in types not being found

[xwipeoutx]

I have the following configuration to install postgis for me:

options.Storage.ExtendedSchemaObjects.Add(new Extension("postgis"));

And the database is created with the extension just fine with this:

await store.Storage.ApplyAllConfiguredChangesToDatabaseAsync();

However, in order to use the types that the extension provides, I'm need to manually do the following:

using (var conn = store.Storage.Database.CreateConnection())
{
    conn.Open();
    conn.ReloadTypes();
    conn.Close();
}

or I get the error:

The NpgsqlDbType 'Geometry' isn't present in your database. You may need to install an extension or upgrade to a newer version.

This is a little clunky, it would be nice if Marten did this for me.

Additionally, if I've set up multi-tenancy via

options.MultiTenantedWithSingleServer(masterConnectionString);

Then the extension is never created - it looks like SingleServerMultiTenancy is never applying any of the extended schema objects defined earlier.

I've worked around this with my own implementation of ITenancy which adds the following to buildDatabase, but it's pretty clunky as well (I'm sure I can use the migrator in here somehow, but this gets me out of the weeds):

    protected override MartenDatabase buildDatabase(string databaseName, string connectionString)
    {
        var connectionFactory = new ConnectionFactory(connectionString);
        var martenDatabase = new MartenDatabase(_options, connectionFactory, databaseName);
        
        // TODO: We can probably use the migrator here or something
        using var conn = martenDatabase.CreateConnection();
        conn.Open();
        conn.Execute("CREATE EXTENSION IF NOT EXISTS \"postgis\";");
        conn.ReloadTypes();
        conn.Close();

        return martenDatabase;
    }

I have put a gist up with this scenario here: https://gist.github.com/xwipeoutx/39e55935e36361095e5e2dc32b711c06

Proposed solution:

• Make sure any schema changes that could cause a change to the ADO types call connection.ReloadTypes()
• Have new databases created via SingleServerMultiTenancy have the extended schema objects applied to them, including reloading the types above

[oskardudycz]

@xwipeoutx that sounds fair to me. Would you be open to contributing to add that? We could try to guide you.

[oskardudycz]

@xwipeoutx, regarding

Have new databases created via SingleServerMultiTenancy have the extended schema objects applied to them, including reloading the types above

See the PR: #2637

Regarding the ReloadTypes scenario, I need to do more investigation.