Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: handle BerkeleyJE DB interruption [tp-tests]" CTR [tp-tests] #4702

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

porunov
Copy link
Member

@porunov porunov commented Oct 17, 2024

This reverts commit 90b9694.
Reason: tp-tests are failing after this commit.

The PR which is being reverted is #4425
The assumed lock-timeout increase didn't help with the issue. Instead a new issue is now happening during tp-tests for BerkeleyJE which can be seen in #4701
If anyone wishes to pick up this work and add the work from #4425 back to JanusGraph, please, feel free to do so by ensuring that all tp-tests are passing.

This PR will re-open: #2120


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

…sts]

This reverts commit 90b9694.
Reason: tp-tests are failing after this commit.

Signed-off-by: Oleksandr Porunov <[email protected]>
@porunov
Copy link
Member Author

porunov commented Oct 17, 2024

@JanusGraph/committers tests for BerkeleyJE are passing after reverting the commit. I'm going to merge it with CTR after all tests are passed, so that we don't have a blocker. If anyone wish to hold on and work on BerkeleyJE issue - let me know.

@porunov porunov merged commit 872a475 into JanusGraph:master Oct 18, 2024
122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant