Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-cedarling): add benchmark for authorization and startup times #10773

Open
rmarinn opened this issue Jan 31, 2025 · 0 comments · May be fixed by #10775
Open

feat(jans-cedarling): add benchmark for authorization and startup times #10773

rmarinn opened this issue Jan 31, 2025 · 0 comments · May be fixed by #10775
Assignees
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-feature Issue or PR is a new feature request

Comments

@rmarinn
Copy link
Contributor

rmarinn commented Jan 31, 2025

Is your feature request related to a problem? Please describe.

Cedarling currently runs locally, which is a significant improvement over making HTTP requests for authorization. However, we want to ensure that performance remains optimal as we make changes, such as caching JWT validation results (#9913). Without proper benchmarking, we lack insight into whether our modifications improve or degrade performance.

Describe the solution you'd like

We should introduce benchmarking to measure key performance metrics, including:

  • Startup time: How long Cedarling takes to initialize.
  • Authorization time: The time taken to process an authorization request.

A clear and concise description of what you want to happen.

We can use the criterion crate, which provides reliable and statistically sound benchmarking capabilities, allowing us to track performance trends over time.

Describe alternatives you've considered

we can also use hyperfine but it's simpler to use criterion since it has rust macros for setting up tests.

Additional context

N/A

@rmarinn rmarinn self-assigned this Jan 31, 2025
@mo-auto mo-auto added comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants