Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jans-cedarling): improve WASM compatibility #10330

Open
rmarinn opened this issue Dec 4, 2024 · 0 comments · May be fixed by #10331
Open

refactor(jans-cedarling): improve WASM compatibility #10330

rmarinn opened this issue Dec 4, 2024 · 0 comments · May be fixed by #10331
Assignees
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-enhancement Issue or PR is an enhancement to an existing functionality
Milestone

Comments

@rmarinn
Copy link
Contributor

rmarinn commented Dec 4, 2024

Is your feature request related to a problem? Please describe.

Cedarling can't compile to WASM because of

  1. the usage of std::time.
  2. the usage of reqwest::blocking::Client

Describe the solution you'd like

  • The chrono crate could be used instead of std::time to fetch the time since it has WASM support.
  • Use the reqwest::Client with the tokio runtime to remove the blocking api.

Describe alternatives you've considered

An alternative solution is to write our own interface to the JS Date API.

Additional context
N/A

@rmarinn rmarinn added comp-jans-cedarling Touching folder /jans-cedarling enhancement labels Dec 4, 2024
@rmarinn rmarinn self-assigned this Dec 4, 2024
@mo-auto mo-auto added the kind-enhancement Issue or PR is an enhancement to an existing functionality label Dec 4, 2024
@rmarinn rmarinn changed the title refactor(jans-cedarling): replace std::time usage with chrono refactor(jans-cedarling): improve WASM compatibility Dec 4, 2024
@rmarinn rmarinn linked a pull request Dec 4, 2024 that will close this issue
6 tasks
@rmarinn rmarinn linked a pull request Dec 4, 2024 that will close this issue
6 tasks
@moabu moabu added this to the next-release milestone Dec 11, 2024
@olehbozhok olehbozhok self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants