Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: react-scripts warnings 정리 #104

Open
md2eoseo opened this issue Oct 11, 2021 · 3 comments
Open

Refactor: react-scripts warnings 정리 #104

md2eoseo opened this issue Oct 11, 2021 · 3 comments
Assignees
Labels
Refactoring 🚜 코드 리팩토링
Milestone

Comments

@md2eoseo
Copy link
Collaborator

리팩토링 문제 사항

  • no-unused-vars
  • react-hooks/exhaustive-deps
  • import/no-anonymous-default-export

리팩토링 방안

no-unused-vars

  • 사용하지 않는 변수 제거

react-hooks/exhaustive-deps

  • useEffect 내 영향을 주는 변수를 dependency로 추가

import/no-anonymous-default-export

  • 익명의 default export module을 변수에 할당하여 export

추가사항

  • react-hooks/exhaustive-deps 경고를 해결할 수 있는 좋은 방법이 있다면 추천 부탁드립니다!
@md2eoseo md2eoseo added the Refactoring 🚜 코드 리팩토링 label Oct 11, 2021
@md2eoseo md2eoseo added this to the 스프린트3 milestone Oct 11, 2021
@md2eoseo md2eoseo self-assigned this Oct 11, 2021
@sjsjsj1246
Copy link
Collaborator

useEffect안에 추가하는건 잘못하면 side-effect를 줄 수 있으니 조심하시길 바랍니다

@md2eoseo
Copy link
Collaborator Author

그래서 useEffect dependency 경고는 그냥 나중에 처리하려 합니다

@sjsjsj1246
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring 🚜 코드 리팩토링
Projects
None yet
Development

No branches or pull requests

3 participants