Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MADR 4.0.0 #11912

Closed
koppor opened this issue Oct 10, 2024 · 5 comments
Closed

Update to MADR 4.0.0 #11912

koppor opened this issue Oct 10, 2024 · 5 comments
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@koppor
Copy link
Member

koppor commented Oct 10, 2024

(This is a non-coding issue)

MADR 4.0.0 was released.

The decisiosn in https://github.com/JabRef/jabref/tree/main/docs/decisions should be updated to that format.

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Oct 10, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Oct 10, 2024
@RabidGhost
Copy link
Contributor

Hi, Ive had a look at the MADR 4.0.0 changes, and the list of decisions you linked. Im a new contributor and i would like to tackle this issue.

Thanks!

@ThiloteE ThiloteE moved this from Free to take to Assigned in Good First Issues Oct 11, 2024
@koppor koppor added 📍 Assigned Assigned by assign-issue-action (or manually assigned) FirstTimeCodeContribution Triggers GitHub Greeter Workflow labels Oct 16, 2024
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

⚠ Note that this issue will become unassigned if it isn't closed within 30 days.

🔧 A maintainer can also add the Pinned label to prevent it from being unassigned automatically.

Happy coding! 🚀

@RabidGhost
Copy link
Contributor

Ive making some small changes only to fix typos and MADR 4.0.0 changes. I found this malformed decision while working. Is this intentional?

Image

Additionally are there any changes to be made other than formatting of decision outcome quotes? It seems the adr-template and most adrs are up to date. Thanks

@koppor
Copy link
Member Author

koppor commented Oct 17, 2024

Ive making some small changes only to fix typos and MADR 4.0.0 changes.

Thank you!

I found this malformed decision while working. Is this intentional?

Thank you for pointing it out. I fixed it at #12006.

Additionally are there any changes to be made other than formatting of decision outcome quotes? It seems the adr-template and most adrs are up to date. Thanks

The template files are not 4.0.0

Check content at https://github.com/adr/madr/tree/develop/template. See that filename of 0000 is different. Please update these, too.

This was referenced Oct 18, 2024
@subhramit
Copy link
Member

I think this is done, hence closing.

@RabidGhost On the correct use of the "Closes" keyword in PR descriptions, either put a "#" and then type the issue number (you can select from the list that appears) or directly copy paste the link to that issue. Manually [Doing something like this](and then putting the link here) will put the hyperlink won't link it to the PR.

Thank you for your contribution!

@github-project-automation github-project-automation bot moved this from Assigned to Done in Good First Issues Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants