Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing to/opening up pure Python comparison engine #11

Open
cam-pressw opened this issue Jul 1, 2024 · 2 comments
Open

Contributing to/opening up pure Python comparison engine #11

cam-pressw opened this issue Jul 1, 2024 · 2 comments

Comments

@cam-pressw
Copy link

Hello! This seems like a great tool, and I would love to help contribute + expand on its capabilities, especially since I need to set up redlining in Python for my use case. I'm also very interested in the pure Python engine, since I'd like to make some modifications to document XML that don't appear to be supported by WmlComparer. Is there any chance the pure Python comparison engine will be surfaced soon? Would love to see if I can help out if more contributors would help the cause!

@JSv4
Copy link
Owner

JSv4 commented Jul 3, 2024

Glad you like the project @cam-pressw. I've done some experimentation with xmldiff, and it appears to be a workable solution. You need to do some work to make sure you're wrapping your diff fragments in the right xml tags, but it can generate xml diffs and create a patch as well. I haven't had time to try to build something production-grade. If you're up to taking a shot at it, I'd be happy to collaborate. I should have enough time to help review.

@cam-pressw
Copy link
Author

cam-pressw commented Jul 3, 2024

Sounds great! Re: wrapping your diff fragments in the right XML tags, I think you mention in the readme that this can get pretty complex. How are you figuring out what tags to use in what situations (comparing outputs from WmlComparer? referencing what XML documentation Microsoft does have?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants