-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicate and rename hdu rgl prio #38
duplicate and rename hdu rgl prio #38
Conversation
|
||
// copying and renaming rgl_prio's hdu if it is the same of init_img | ||
if (selectedInputImageHDU == selectedRglPrioImage) { | ||
selectedRglPrioImage = new FitsImageHDU(selectedInputImageHDU); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use local variable to not alter the user selection = selectedRglPrioImage !
selectedRglPrioImage.setHduName(newHduName); | ||
oifitsFile.getImageOiData().getInputParam().setRglPrio(newHduName); | ||
} | ||
|
||
oifitsFile.getFitsImageHDUs().add(selectedRglPrioImage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GUI and input file are now inconsistent !
Having a duplicate renamed HDU for RGL_PRIO must be valid in the input form, thus this HDU must be an item of the RGL_PRIO of the combo box, thus it must be present in the image library. Thus we have duplicates in the image library. We can :
|
That's too painful. I tested and BSMEM works with duplicated HDU (same HDU_NAME), let's wait. |
Finally I prefer the 2nd solution: when calling the IR software, the input OIFits structure in memory is written to a temporary file (before sending it through http) so it seems the good place to fix the generated OIFITS file to be really valid (FITS + OIFITS + Fits image validation) and the writeOIFitsFile() can pre-process / adjust the generated nom.tam Fits HDU ... See |
It was not difficult to do it in |
I am just proposing a possible solution to fix the OIFITS file (duplicate HDU + fix HDU_NAME only before writing file) that seems less complicated than fixing the all GUI to handle HDU duplicatton on the fly if INIT_IMG = RGL_PRIOR (same choice) ! |
Closed and maybe revisited later after a review with software authors organized by @FerreolS |
No description provided.