Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOFTWARE and VERSION #10

Closed
FerreolS opened this issue Oct 19, 2021 · 13 comments
Closed

SOFTWARE and VERSION #10

FerreolS opened this issue Oct 19, 2021 · 13 comments
Assignees

Comments

@FerreolS
Copy link
Member

We should add a software (or algorithm) and software version keywords in IMAGE-OI OUTPUT PARAM :

  • SOFTWARE
  • SOFT_VER
@FerreolS
Copy link
Member Author

Up to now, there is no way to know which software was used to create an OI-Interface image. We could use an heuristic to infer it but I think, it should be in the standard somehow

@jsy1001
Copy link
Contributor

jsy1001 commented Nov 30, 2021

The ESO standard is:

PROCSOFT Indicates the reduction software system including its version number used
to produce this data product.

@FerreolS
Copy link
Member Author

Ok. PROCSOFT keyword may be already used by the reduction pipeline. As an example, PIONIER oifits files contains in the primary header :
PROCSOFT= 'pndrs_v3.52' / Data reduction software and version
Is setting the algorithm in PROCSOFT keyword in IMAGE-OI OUTPUT PARAM hdu is sufficiently clear?

@jsy1001
Copy link
Contributor

jsy1001 commented Nov 30, 2021

I think its clear from the context of being in a different hdu.

@GillesDuvert
Copy link

there is already VERSION ?

@FerreolS
Copy link
Member Author

There in no eso keyword for version. The version number seems to be usually added to the software name in the PROCSOFT keyword

@emmt
Copy link
Collaborator

emmt commented Feb 21, 2022

Now that I have the hands in MiRA, I am going to give a try to PROCSOFT as follows (emmt/MiRA@c666226):

PROCSOFT= 'MiRA v2.3.2' / Data reduction software and version

@jsy1001
Copy link
Contributor

jsy1001 commented Mar 2, 2022

For bsmem see https://gitlab.com/jsy1001/bsmem/-/issues/9

@jsy1001
Copy link
Contributor

jsy1001 commented Mar 2, 2022

I've implemented PROCSOFT for bsmem.

@buthanoid
Copy link
Member

I created an issue for OImaging JMMC-OpenDev/oimaging#96

@GillesDuvert
Copy link

What would be the version of Wisard at any moment? At the moment it is 3.2.2 . This is not an internal Wisard number, it is a Github release number triggered by Laurent. It would be nice to have PROCSOFT set to the release number 'automatically'. Since the number is a string, I figure a GH script could insert the actual release number in the Wisard "code", as it is not compiled but just a procedure.
Any other solution leads to a discrepancy between PROCSOFT and the only number availble around, the GH release number. Or am I confused?

@FerreolS
Copy link
Member Author

FerreolS commented Mar 3, 2022

Ok. That seems doable, it is probably just a few lines to add in the dockerfile : https://github.com/JMMC-OpenDev/oimaging-uws-server/blob/master/runtime/docker/oiservices/Dockerfile

@jsy1001
Copy link
Contributor

jsy1001 commented Mar 7, 2022

We should document this usage of PROCSOFT in the specification document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants