Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSUHYUNKIM
added
✔︎pull requests
kmw2378
reviewed
Dec 22, 2024
src/main/java/ject/componote/domain/bookmark/api/BookmarkController.java
Outdated
Show resolved
Hide resolved
src/main/java/ject/componote/domain/bookmark/application/BookmarkService.java
Outdated
Show resolved
Hide resolved
src/main/java/ject/componote/domain/bookmark/application/BookmarkService.java
Outdated
Show resolved
Hide resolved
src/main/java/ject/componote/domain/bookmark/application/BookmarkService.java
Outdated
Show resolved
Hide resolved
src/main/java/ject/componote/domain/bookmark/domain/BookmarkRepository.java
Outdated
Show resolved
Hide resolved
kmw2378
approved these changes
Dec 22, 2024
kmw2378
reviewed
Jan 2, 2025
Comment on lines
+34
to
+35
| @RequestParam(required = false, defaultValue = "component") String type, | ||
| @RequestParam(required = false, defaultValue = "createdAt") String sortType) { |
There was a problem hiding this comment.
파라미터가 2개 이상이면 별도 DTO를 사용하는게 어떨까요?
Comment on lines
+132
to
+163
| private Pageable applySort(Pageable pageable, String type, String sortType) { | ||
| Sort sort; | ||
|
|
||
| if ("createdAt".equals(sortType)) { | ||
| sort = Sort.by(Sort.Order.desc("createdAt")); | ||
| } | ||
| else if ("name".equals(sortType) && "component".equals(type)) { | ||
| sort = Sort.by(Sort.Order.asc("summary.title")) | ||
| .and(Sort.by(Sort.Order.desc("createdAt"))); | ||
| } else if ("viewCount".equals(sortType) && "component".equals(type)) { | ||
| sort = Sort.by(Sort.Order.desc("summary.viewCount")) | ||
| .and(Sort.by(Sort.Order.desc("createdAt"))); | ||
| } else if ("commentCount".equals(sortType) && "component".equals(type)) { | ||
| sort = Sort.by(Sort.Order.desc("commentCount")) | ||
| .and(Sort.by(Sort.Order.desc("createdAt"))); | ||
| } | ||
|
|
||
| else if ("name".equals(sortType) && "designSystem".equals(type)) { | ||
| sort = Sort.by(Sort.Order.asc("summary.name")) | ||
| .and(Sort.by(Sort.Order.desc("createdAt"))); | ||
| } else if ("viewCount".equals(sortType) && "designSystem".equals(type)) { | ||
| sort = Sort.by(Sort.Order.desc("summary.viewCount")) | ||
| .and(Sort.by(Sort.Order.desc("createdAt"))); | ||
| } else if ("recommendCount".equals(sortType) && "designSystem".equals(type)) { | ||
| sort = Sort.by(Sort.Order.desc("summary.recommendCount")) | ||
| .and(Sort.by(Sort.Order.desc("createdAt"))); | ||
| } else { | ||
| sort = Sort.by(Sort.Order.desc("createdAt")); | ||
| } | ||
|
|
||
| return PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort); | ||
| } |
There was a problem hiding this comment.
컨트롤러에서 Pageable을 전달받을 때 이 과정이 다 처리가 되는데 별도로 메서드로 처리하는 이유가 있을까요?
|
|
||
| private Bookmark(final Long memberId, final Long componentId) { | ||
| @Column(name = "type", nullable = false) | ||
| private String type; |
|
|
||
| @RequiredArgsConstructor | ||
| @Service | ||
| public class BookmarkService { |
There was a problem hiding this comment.
컴포넌트, 디자인 시스템 북마크를 하나로 처리하려 하니 전반적으로 코드 가독성과 확장성이 부족한 것 같아요 ㅜㅜ
차라리 별도 테이블로 분리한다면 로직들이 더 단순해질 것 같습니다!
참고로, 컴포넌트 검색, 상세 페이지에서 북마크 여부를 확인하는데 북마크 테이블이 분리된다면 이 기능에서도 성능 향상이 있을 것 같습니다.
kmw2378
reviewed
Jan 3, 2025
| @@ -0,0 +1,8 @@ | |||
| package ject.componote.domain.bookmark.dto.request; | |||
|
|
|||
| import com.google.firebase.database.annotations.NotNull; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
테스트
Repository
Service
Controller
기타 사항 (참고 자료, 문의 사항 등)