Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional maxPerAddress parameter in the marketplace #45

Closed
damienen opened this issue Apr 8, 2024 · 5 comments
Closed

Add an optional maxPerAddress parameter in the marketplace #45

damienen opened this issue Apr 8, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@damienen
Copy link
Member

damienen commented Apr 8, 2024

Requirements:

  1. Whenever someone lists they can specify an optional maxQuantity parameter which limits how many of those NFTs an address can buy
  2. If they don't send such a parameter, the maxDefaultQuantity is set to be used instead
@newbreedofgeek newbreedofgeek added the enhancement New feature or request label Apr 9, 2024
bucurdavid added a commit that referenced this issue Apr 9, 2024
bucurdavid added a commit that referenced this issue Apr 9, 2024
@bucurdavid
Copy link
Member

Should be delivered with this PR: Itheum/sdk-mx-data-nft#129

@damienen
Copy link
Member Author

Seems like you added a maxQuantity per TX, but a max quantity per ADDRESS is needed. (see updated descriprition above as well)

bucurdavid added a commit that referenced this issue Apr 17, 2024
bucurdavid added a commit that referenced this issue Apr 17, 2024
@damienen damienen self-assigned this Apr 18, 2024
@damienen
Copy link
Member Author

Code reviewed. Looks good. But to be noted: it's a breaking changes for the addOffer endpoint

@damienen damienen removed their assignment Apr 22, 2024
bucurdavid added a commit that referenced this issue Apr 22, 2024
@damienen damienen reopened this Apr 23, 2024
@damienen
Copy link
Member Author

damienen commented Apr 23, 2024

pub struct OfferOut<M: ManagedTypeApi> {

We should return how much the user can buy on his address for each offer in offer out (not how much IN TOTAL, but how much considering what he has bought so far)

Change should be reflected in the SDK as well

bucurdavid added a commit that referenced this issue Apr 25, 2024
bucurdavid added a commit that referenced this issue Apr 25, 2024
@damienen
Copy link
Member Author

Solved. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants