Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling/grammar fixes #22

Open
10 tasks
petersmythe opened this issue Jun 27, 2024 · 2 comments
Open
10 tasks

Spelling/grammar fixes #22

petersmythe opened this issue Jun 27, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@petersmythe
Copy link
Contributor

Level: Low

Describe the bug:
Spelling/grammar. Are these pages available on GitHub for a PR, or must I highlight fixes by listing them below?

Steps To Reproduce:

View https://developer.investec.com/za/programmable-card

Expected behaviour:

  • Perform transaction simulations using online the simulator -> Perform transaction simulations using the online simulator
  • return false will decline a authorization. -> return false will decline an authorization.
  • Apply conditional logic within before transaction method Say -> Apply conditional logic within before transaction method. Say
  • for your to interact/communicate -> for you to interact/communicate
  • such as updating a external DB -> such as updating an external DB
  • Within env.json, you are able to save variable - a variable -> Within env.json, you are able to save a variable
  • may be created and available -> may be created and are available
  • Once a environment variable has been defined -> Once an environment variable has been defined

Additionally

  • main.js requires two methods for card transaction interception
    We might want to review this. Yes, it only requires these 2, but if it doesn't have afterDecline and the transaction is declined, then there is an error in the logs.
  • Consistent spelling of "before transaction" and consistent use of back ticks '`' for methods/filenames/code snippets.
@petersmythe petersmythe changed the title [GENERAL BUG] A short description here. Spelling/grammar fixes Jun 27, 2024
@programmable-banking-community programmable-banking-community added the documentation Improvements or additions to documentation label Jun 27, 2024
@petersmythe
Copy link
Contributor Author

main.js requires two methods for card transaction interception

See also https://github.com/orgs/Investec-Developer-Community/discussions/14#discussioncomment-9352461

@programmable-banking-community
Copy link
Contributor

Hi Peter. The official docs on developer.investec.com are not publicly editable (yet - we are working on that). In the meantime, the team will take a look at these and see how best we can action them. Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants