Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Legacy DRep Metadata Format: Transition to CIP-0119 #2509

Open
kneerose opened this issue Dec 11, 2024 · 1 comment
Open

🐛 Legacy DRep Metadata Format: Transition to CIP-0119 #2509

kneerose opened this issue Dec 11, 2024 · 1 comment
Assignees
Labels
🐛 Bug Something isn't working Other area

Comments

@kneerose
Copy link
Contributor

Area

Other

Domain

dev-sanchogov.tools

Which wallet were you using?

No response

Context

Currently, the DRep metadata uses an outdated format instead of the updated structure defined in CIP-0119.

Example of current dRep metadata format use in govtool

{
  "@context": {
    "@language": "en-us",
    "CIP100": "https://github.com/cardano-foundation/CIPs/blob/master/CIP-0100/README.md#",
    "CIP119": "https://github.com/cardano-foundation/CIPs/blob/master/CIP-0119/README.md#",
    "hashAlgorithm": "CIP100:hashAlgorithm",
    "body": {
      "@id": "CIP119:body",
      "@context": {
        "references": {
          "@id": "CIP119:references",
          "@container": "@set",
          "@context": {
            "GovernanceMetadata": "CIP100:GovernanceMetadataReference",
            "Identity": "CIP119:IdentityReference",
            "Link": "CIP119:LinkReference",
            "Other": "CIP100:OtherReference",
            "label": "CIP100:reference-label",
            "uri": "CIP100:reference-uri",
            "referenceHash": {
              "@id": "CIP119:referenceHash",
              "@context": {
                "hashDigest": "CIP119:hashDigest",
                "hashAlgorithm": "CIP100:hashAlgorithm"
              }
            }
          }
        },
        "paymentAddress": "CIP119:paymentAddress",
        "givenName": "CIP119:givenName",
        "image": "CIP119:image",
        "objectives": "CIP119:objectives",
        "motivations": "CIP119:motivations",
        "qualifications": "CIP119:qualifications",
        "doNotList": "CIP119:doNotList"
      }
    },
    "authors": {
      "@id": "CIP100:authors",
      "@container": "@set",
      "@context": {
        "name": "http://xmlns.com/foaf/0.1/name",
        "witness": {
          "@id": "CIP100:witness",
          "@context": {
            "witnessAlgorithm": "CIP100:witnessAlgorithm",
            "publicKey": "CIP100:publicKey",
            "signature": "CIP100:signature"
          }
        }
      }
    }
  },
  "authors": [],
  "hashAlgorithm": {
    "@value": "blake2b-256"
  },
  "body": {
    "doNotList": false,
    "givenName": {
      "@value": "sadsad"
    },
    "motivations": {
      "@value": "asdsad"
    },
    "objectives": {
      "@value": "sadsad"
    },
    "paymentAddress": {
      "@value": ""
    },
    "qualifications": {
      "@value": ""
    },
    "references": []
  }
}

According to CIP-0119, the metadata should follow this example.

Steps to reproduce

  1. Connect to the wallet.
  2. Register as a DRep.
  3. Download the metadata.
  4. Compare the format with the CIP-0119 specifications.

Actual behavior

The dRep metadata format still follows the old structure instead of the new one defined by CIP-0119.

Expected behavior

The DRep metadata should conform to the updated format specified in CIP-0119.

@MSzalowski
Copy link
Contributor

That example DRep metadata doesn't provide language property that is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working Other area
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants